Merge pull request #4143 from sanger/y24-069-submission-filename-too-…

…long-2

Y24-069-2 Only show a single barcode when one is entered

app/controllers/bulk_submission_excel/downloads_controller.rb

@@ -73,12 +73,11 @@ def submission_parameters
   # Follows the format: first barcode_to_last barcode_date_sanger user ID
   # e.g. "SQPP-1234_to_SQPP-5678_20240521_ec20.xlsx"
   def build_filename(barcodes)
-    first_barcode = barcodes.first
-    last_barcode = barcodes.last
     date = Time.current.utc.strftime('%Y%m%d')
     username = current_user.login
+    barcode_part = barcodes.one? ? barcodes.first.to_s : "#{barcodes.first}_to_#{barcodes.last}"
 
-    "#{first_barcode}_to_#{last_barcode}_#{date}_#{username}.xlsx"
+    "#{barcode_part}_#{date}_#{username}.xlsx"
   end
 
 end

spec/controllers/bulk_submission_excel/downloads_controller_spec.rb

@@ -64,7 +64,7 @@
         it 'generates an Excel file with the correct headers' do
           post :create, params: valid_attributes
           expect(response.headers['Content-Disposition']).to include(
-            "#{barcodes.first}_to_#{barcodes.first}_#{Time.current.utc.strftime('%Y%m%d')}_#{session[:user].login}.xlsx"
+            "#{barcodes.first}_#{Time.current.utc.strftime('%Y%m%d')}_#{session[:user].login}.xlsx"
           )
         end
       end