Skip to content

Commit

Permalink
refactor the tests
Browse files Browse the repository at this point in the history
  • Loading branch information
wendyyang committed Sep 19, 2024
1 parent 3a8e122 commit cc0703d
Showing 1 changed file with 9 additions and 9 deletions.
18 changes: 9 additions & 9 deletions spec/models/comment_spec.rb
Original file line number Diff line number Diff line change
Expand Up @@ -18,28 +18,28 @@
end

describe '#counts_for_requests' do
let(:request1) { create :sequencing_request, asset: tube }
let(:tube) { create :multiplexed_library_tube }

let(:request2) { create :sequencing_request }

context 'when request has asset' do
let(:request) { create :sequencing_request, asset: tube }
let(:tube) { create :multiplexed_library_tube }

before do
create :comment, commentable: tube, description: 'An excellent tube'
create :comment, commentable: tube.receptacle, description: 'A good receptacle'
create :comment, commentable: request1, description: 'A reasonable request1'
create :comment, commentable: request, description: 'A reasonable request'
end

it 'counts comments on requests, their assets and receptacles' do
expect(described_class.counts_for_requests([request1])).to eq({ request1.id => 3 })
expect(described_class.counts_for_requests([request])).to eq({ request.id => 3 })
end
end

context 'when request has no asset' do
before { create :comment, commentable: request2, description: 'A reasonable request2' }
let(:request) { create :sequencing_request }

before { create :comment, commentable: request, description: 'A reasonable request' }

it 'counts comments on requests only' do
expect(described_class.counts_for_requests([request2])).to eq({ request2.id => 1 })
expect(described_class.counts_for_requests([request])).to eq({ request.id => 1 })
end
end
end
Expand Down

0 comments on commit cc0703d

Please sign in to comment.