Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

DPL-1003 sample prep create an RNA stock plate from extraction lims #293

Open
wants to merge 3 commits into
base: develop
Choose a base branch
from
+13 −13
Open

DPL-1003 sample prep create an RNA stock plate from extraction lims #293

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
7da89d0
Replaced "RNA Stock Plate" with "Stock RNA Plate" to match the Sequen…
yoldas Dec 19, 2023
4b530e8
Terminated rules in test inference data to avoid parser errors
yoldas Dec 19, 2023
6809757
Merge branch 'develop' into 3971-dpl-1003-sample-prep-create-an-rna-s…
yoldas Jan 8, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/actions/racking.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ def html_error_message(error_messages)
module Actions
module Racking # rubocop:todo Style/Documentation
DNA_STOCK_PLATE_PURPOSE = 'DNA Stock Plate'
RNA_STOCK_PLATE_PURPOSE = 'RNA Stock Plate'
RNA_STOCK_PLATE_PURPOSE = 'Stock RNA Plate'
STOCK_PLATE_PURPOSE = 'Stock Plate'
DNA_ALIQUOT = 'DNA'
RNA_ALIQUOT = 'RNA'
Expand Down
2 changes: 1 addition & 1 deletion script/container_inferences.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ def containers

def purpose_for_aliquot(aliquot)
return 'DNA Stock Plate' if aliquot == 'DNA'
return 'RNA Stock Plate' if aliquot == 'RNA'
return 'Stock RNA Plate' if aliquot == 'RNA'

return 'Stock Plate'
end
Expand Down
4 changes: 2 additions & 2 deletions script/purpose_name_inference.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -19,7 +19,7 @@ def _CODE
?asset :contains ?anotherAsset .
?anotherAsset :aliquotType """RNA""" .
}=>{
:step :addFacts { ?asset :purpose """RNA Stock Plate""" } .
:step :addFacts { ?asset :purpose """Stock RNA Plate""" } .
} .

@forAll :anotherAsset, :someAliquot .
Expand Down Expand Up @@ -53,7 +53,7 @@ def containers

def purpose_for_aliquot(aliquot)
return 'DNA Stock Plate' if aliquot == 'DNA'
return 'RNA Stock Plate' if aliquot == 'RNA'
return 'Stock RNA Plate' if aliquot == 'RNA'

return 'Stock Plate'
end
Expand Down
2 changes: 1 addition & 1 deletion script/runners/transfer_tubes_to_tube_rack_by_position.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -140,7 +140,7 @@ def process
if (aliquot_types.uniq.length == 1) && (aliquot_types.uniq.first == 'DNA')
purpose_name = 'DNA Stock Plate'
elsif (aliquot_types.uniq.length == 1) && (aliquot_types.uniq.first == 'RNA')
purpose_name = 'RNA Stock Plate'
purpose_name = 'Stock RNA Plate'
else
purpose_name = 'Stock Plate'
end
Expand Down
8 changes: 4 additions & 4 deletions spec/integration/inferences_data.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,7 +27,7 @@ def inferences_data
?y :t ?_val .
} => {
:step :addFacts {?x :val ?_val }.
}
}.
yoldas marked this conversation as resolved.
Show resolved Hide resolved

',
inputs:
Expand Down Expand Up @@ -58,7 +58,7 @@ def inferences_data
?y :t ?_pos .
} => {
:step :addFacts {?x :relates_with ?y }.
}
}.
',
inputs:
'
Expand Down Expand Up @@ -95,7 +95,7 @@ def inferences_data
?y :a "TubeB" .
} => {
:step :addFacts { ?y :transferredFrom ?x . }.
}
}.
',
inputs:
'
Expand Down Expand Up @@ -284,7 +284,7 @@ def inferences_data
} => {
:step :addFacts {?rack :is "TubeRack" .} .
:step :addFacts {?rack :location ?_position .} .
}
}.
',
inputs:
'
Expand Down
4 changes: 2 additions & 2 deletions spec/lib/actions/racking_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -169,8 +169,8 @@ def add_empty_slots(content, num_empty, start_pos = 0)
context 'when an RNA tube' do
let(:aliquot_type) { 'RNA' }

it 'generates the RNA stock plate purpose' do
expect(updates.to_h[:add_facts].find { |triple| triple[1] == 'purpose' }[2]).to eq('RNA Stock Plate')
it 'generates the stock RNA plate purpose' do
expect(updates.to_h[:add_facts].find { |triple| triple[1] == 'purpose' }[2]).to eq('Stock RNA Plate')
end
end
end
Expand Down
4 changes: 2 additions & 2 deletions spec/script/runners/transfer_tubes_to_tube_rack_by_position_spec.rb
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -100,12 +100,12 @@
end
context 'when it is RNA' do
let(:aliquot) { aliquot_rna }
it 'will set up an RNA Stock plate purpose' do
it 'will set up a Stock RNA plate purpose' do
added_facts = instance.process.to_h[:add_facts]
purposes = added_facts.select { |triple| triple[1] == 'purpose' }
expect(purposes.size).to eq(1)
expect(purposes.first[0]).to eq(rack.uuid)
expect(purposes.first[2]).to eq('RNA Stock Plate')
expect(purposes.first[2]).to eq('Stock RNA Plate')
end
end

Expand Down
Loading