Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ignore .vscode #3710

Merged
merged 1 commit into from
Feb 18, 2024
Merged

Ignore .vscode #3710

merged 1 commit into from
Feb 18, 2024

Conversation

wwahammy
Copy link
Contributor

Anyone using VSCode with the project will have their local VSCode config settings added at .vscode/. Since these are generally unique to the individual and customized, it's easy to unintentionally add these to a commit unless they're gitignored. So we're doing that here.

@ocdtrekkie

This comment has been minimized.

@kpreid
Copy link

kpreid commented Feb 18, 2024

is there any way to include it at the root and include any given .vscode directory one might have?

This is the default behavior for names with no /. From git docs:

If there is a separator at the beginning or middle (or both) of the pattern, then the pattern is relative to the directory level of the particular .gitignore file itself. Otherwise the pattern may also match at any level below the .gitignore level.

@ocdtrekkie
Copy link
Collaborator

@kpreid I knew there was one behavior or another for it, I just don't play with it often enough.

So this change just needs to be moved to the root gitignore.

@ocdtrekkie
Copy link
Collaborator

ocdtrekkie commented Feb 18, 2024

Or I misread the commit entirely and shouldn't review PRs on my phone.

edit: For historical self-shaming practices, here's what happened: The diff view on my phone highlighted a /tests line above in the gitignore, and I thought this was a PR against the gitignore in /tests at a glance. The PR is correct, I was not.

@ocdtrekkie ocdtrekkie added the sandstorm-dev Issues hacking on Sandstorm label Feb 18, 2024
@ocdtrekkie ocdtrekkie merged commit 63f265d into sandstorm-io:master Feb 18, 2024
1 check failed
@ocdtrekkie
Copy link
Collaborator

Merged (from a desktop!)

@wwahammy wwahammy deleted the ignore-.vscode branch February 18, 2024 22:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
sandstorm-dev Issues hacking on Sandstorm
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants