Propagate error on LDAPS SSL cert verification failure #3136
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for this! Silent failures are always a little unfortunate for troubleshooting. |
kentonv
reviewed
Mar 15, 2020
|
|
||
| try { | ||
| ldapBindFut.wait(); | ||
| } catch (err) { | ||
| return { error: err }; | ||
| } | ||
| } | ||
|
|
||
| client.on("error", errorFunc); |
There was a problem hiding this comment.
Is it intended that we may end up registering multiple on-error handlers? What is the effect of running both? You moved this line down here, so I guess ordering is important? Might be worth a comment explaining that this is expected, otherwise it looks like it could be a mistake.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #3012.
The problem was that failing to verify the cert emits an
errorrather than calling the error callback, soerrorFuncwould catch the error andldapBindFutwould never return/throw.