Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

* Added Alt Actions for Wings #126

Closed
wants to merge 2 commits into from

Conversation

jrconway3
Copy link

@jrconway3 jrconway3 commented Apr 24, 2024

Related to this issue:
#88

I'm going to try and keep adding as many of these assets as possible so that eventually there will be enough to add these alternate animations.

This adds run (both base run and Eliza's revised run), jump, and idle animations for the wings. I also added the release on OGA (https://opengameart.org/content/lpc-new-wing-animations-original-by-elizawy) as well as a link to Eliza's repo for the original wing assets to the credits.

@sanderfrenken
Copy link
Owner

I think it would be really nice to add the alternative animations (jump, climb, idle etc) as well.

The form of how to do this though, that is to be determined.
I think we should start with the body sheets. Using the custom animation handler however, is too slow. Moreover, the custom animation handler is meant for reusing existing animation frames in a new sequence combined with an accessoire sheet that fits it (like a backward slash animation).

Therefore, as these new animations are in fact new frames I think the most efficient way would be to add them to the universal sheet.

As such, adding the loose animation sheets as done here will not serve the purpose.

What do you think?

@sanderfrenken
Copy link
Owner

Btw I know you added them for some other sheets already, that is fine: we can clean that up if we go in the universal sheet direction. First we need a strategy:)

@sanderfrenken
Copy link
Owner

Plus.. Lets move the discussion to the issue about this topic :)

@jrconway3 jrconway3 closed this Apr 27, 2024
@jrconway3
Copy link
Author

I opened a new PR with the idea in mind of expanding the main sheet instead. In my testing, it appears that expanding the main sheet works fine even when individual asset sheets don't have the full size, so we can deploy that without breaking anything else, and gradually fill out new assets for these sheets. Then we can open up issues on a case-by-case basis for various pieces.

@jrconway3 jrconway3 deleted the alt-actions-wings branch May 1, 2024 00:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants