Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Ember.emberDeprecate is not a function #540

Merged
merged 2 commits into from
Feb 11, 2021
Merged

Fix Ember.emberDeprecate is not a function #540

merged 2 commits into from
Feb 11, 2021

Commits on Feb 10, 2021

  1. fix: import deprecate from documented module 

    The internal `deprecate` wrapper imports Ember's deprecation utility from a different location than the documented one.

`deprecate` documentation: https://api.emberjs.com/ember/3.24/functions/@ember%2Fdebug/deprecate
    @alexlafroscia
    alexlafroscia committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    1779243 View commit details
    Browse the repository at this point in the history

  2. fix: avoid renaming function on import 

    For some reason, the Ember Babel plugin isn’t working when we re-name the `deprecate` function while importing; it results in the code being converted into

`Ember.emberDeprecate`

Rather than

`Ember.deprecate`

And that function is, understandably, not defined.

I thought the issue might be the dated version of `ember-cli-babel` but updating that doesn’t seem to actually solve the problem.
    @alexlafroscia
    alexlafroscia committed Feb 10, 2021
    Configuration menu
    Copy the full SHA
    b577bf2 View commit details
    Browse the repository at this point in the history