Skip to content

Commit

Permalink
Adds $ declaration to all files where $ is used without Ember. prefix
Browse files Browse the repository at this point in the history
  • Loading branch information
mkeemon committed Jul 20, 2016
1 parent 8d1e45f commit 8c70c13
Show file tree
Hide file tree
Showing 3 changed files with 7 additions and 0 deletions.
2 changes: 2 additions & 0 deletions test-support/page-object/create.js
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,8 @@ import clickable from './properties/clickable';
import contains from './properties/contains';
import text from './properties/text';

const { $ } = Ember;

function Node() {
this.isHidden = isHidden().propertyFor(this, 'isHidden');
this.isVisible = isVisible().propertyFor(this, 'isVisible');
Expand Down
2 changes: 2 additions & 0 deletions test-support/page-object/helpers.js
Original file line number Diff line number Diff line change
@@ -1,5 +1,7 @@
import Ember from 'ember';

const { $ } = Ember;

export function qualifySelector(...selectors) {
return selectors.filter(item => !!item).join(' ');
}
Expand Down
3 changes: 3 additions & 0 deletions test-support/page-object/properties/custom-helper.js
Original file line number Diff line number Diff line change
@@ -1,7 +1,10 @@
import { create } from '../create';
import Descriptor from '../descriptor';
import Ember from 'ember';
import { qualifySelector } from '../helpers';

const { $ } = Ember;

function action(target, key, options, ...args){
let selector = qualifySelector(options.scope || target.scope, options.selector);

Expand Down

0 comments on commit 8c70c13

Please sign in to comment.