Merge pull request #6355 from samvera/valk-fix-add-file-version

Make fileset representative_id and thumbnail_id readonly in form
samvera · Oct 10, 2023 · 191c31a · 191c31a
2 parents 3d8038b + 88c8f4b
commit 191c31a
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 10 deletions.
diff --git a/app/forms/hyrax/forms/file_set_form.rb b/app/forms/hyrax/forms/file_set_form.rb
@@ -12,8 +12,8 @@ class FileSetForm < Hyrax::Forms::ResourceForm
       # be configurable.
       include Hyrax::FormFields(:file_set_metadata)
 
-      property :representative_id, type: Valkyrie::Types::String
-      property :thumbnail_id, type: Valkyrie::Types::String
+      property :representative_id, type: Valkyrie::Types::String, writeable: false
+      property :thumbnail_id, type: Valkyrie::Types::String, writeable: false
     end
   end
 end
diff --git a/app/models/hyrax/file_set.rb b/app/models/hyrax/file_set.rb
@@ -103,14 +103,6 @@ def representative_id
       id
     end
 
-    ##
-    # @return [Valkyrie::ID]
-    def representative_id=(_input)
-      # saving a file set using valkyrie would err because this method didn't exist.
-      Rails.logger.warn('This is not a valid method for file sets')
-      id
-    end
-
     ##
     # @return [Boolean] true
     def pcdm_object?