Rust 1.73 updates #298
Rust 1.73 updates #298
Conversation
| @@ -14,7 +14,7 @@ keywords = ["compiler", "bril", "parser", "data-structures", "language"] | |||
| # See more keys and their definitions at https://doc.rust-lang.org/cargo/reference/manifest.html | |||
|
|
|||
| [dependencies] | |||
| clap = { version = "4.3", features = ["derive"] } | |||
| clap = { version = "4.4", features = ["derive"] } | |||
There was a problem hiding this comment.
It's obviously not important now, but it occurs to me that we could consider setting up a Cargo workspace to centralize dependency versions like this.
There was a problem hiding this comment.
I can, but there are two usability issues as far as I can tell.
One I knew about previously is that if you run a cargo command at the workspace level(compared to the crate level) then it will try to union all the possible feature flags of each dependency together. This is incompatible with some of the projects that only expect a subset of the bril-rs flags(a bril* tool that doesn't expect bril-rs to be built with positions for instance).
One minor thing I just figured out is that there are other settings that previously local would be forced to be workspace wide. Specifically for brillvm it is important to have panic = "abort" lto = true set for building/linking the no_std rt library. With a workspace, this gets forced upon all of the projects which isn't ideal(but not breaking/work around-able in this case I think). rust-lang/cargo#8264 (comment)
There was a problem hiding this comment.
Makes sense! That first argument seems like sufficient reason not to do this (since bril-rs is meant to be a very configurable crate).
See commit messages