More tests and a fix for SSA conversion (from #119) #134
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is similar to the functional stack passing fix in #119 but has a smaller fix (just clobber the stacks altogether before restoring the old values; previously we just overwrote the new variables).
The current state of the SSA examples can leave references to an intentionally undefined variable (`__undefined`) in situations where it thinks the value will never be used. So we allow ourselves to run trivial DCE to clean up these assignments before attempting to run the code.
Will discuss current status in #108.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pulls out a few pieces of #119 without doing the "big change" to fix undefined values in SSA conversion:
ssa_roundtriptests that convert to SSA, back out of SSA, and then interprets the result to ensure that they don't crash.to_ssa.pywith some CFGs where the recursive calls wouldn't property clear the stack names. (I used a simpler fix than the one in [SSA] Fix up to_ssa.py and add test cases #119.)This doesn't fix the big outstanding issue in #108, but it preserves some test (suffixed
.BROKEN) that demonstrate the problem.