Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

smbtorture: Add Shadow Copy related tests #82

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

smbtorture: Add Shadow Copy related tests #82

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions testcases/smbtorture/selftest/flapping.cephfs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,3 +20,9 @@ samba3.smb2.timestamps.time_t_1968
# https://github.com/samba-in-kubernetes/sit-environment/pull/109
# Note: CephFS(vfs) successfully completes smb2.session.reauth4.
samba3.smb2.session.reauth4

# https://github.com/samba-in-kubernetes/sit-test-cases/issues/86
samba3.smb2.ioctl.sparse_punch
samba3.smb2.ioctl.sparse_qar_ob1
samba3.smb2.ioctl.copy-chunk*
samba3.smb2.ioctl.sparse_punch_invalid
3 changes: 3 additions & 0 deletions testcases/smbtorture/selftest/flapping.glusterfs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@

#https://github.com/gluster/samba-integration/issues/241
^samba3.smb2.deny.*

# Strictly checking ioctl tests against cephFS only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

How does dropping a comment in the flapping.glusterfs file restrict these test to run against cephfs?

Copy link
Collaborator Author

@Shwetha-Acharya Shwetha-Acharya Aug 14, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@obnoxxx idea here was to add these tests flapping(sometimes fails or sometimes passes) under all other filesystems other than cephFS. As of now I am trying to check this test strictly for cephFS, that is why it is not added under flapping.cephfs

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fair enough.Makes sense!

^samba3.smb2.ioctl.*
3 changes: 3 additions & 0 deletions testcases/smbtorture/selftest/flapping.gpfs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@
# Ignore due to lack of proper multichannel setup.
^samba3.smb2.session.bind2
^samba3.smb2.session.two_logoff

# Strictly checking ioctl tests against cephFS only
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as before: how does a comment to flapping.gpfs restrict tests to cephfs?

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@Shwetha-Acharya , please also investigate failed ci checks!

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same question as before: how does a comment to flapping.gpfs restrict tests to cephfs?

Same answer as above

^samba3.smb2.ioctl.*
3 changes: 3 additions & 0 deletions testcases/smbtorture/selftest/flapping.xfs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@

# https://github.com/samba-in-kubernetes/sit-environment/pull/109
samba3.smb2.session.reauth4

# Strictly checking ioctl tests against cephFS only
^samba3.smb2.ioctl.*
1 change: 1 addition & 0 deletions testcases/smbtorture/smbtorture-tests-info.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@
- smb2.bench
- smb2.winattr2
- smb2.charset
- smb2.ioctl
Loading