Update selftests #57
Merged
Update selftests #57
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I figured that flapping.cephfs is missing another set of subtests( |
anoopcs9
reviewed
Jan 17, 2024
spuiuk
force-pushed
the
update_selftests
branch
2 times, most recently
from
6a7fb3c
to
bc874a0
Compare
anoopcs9
force-pushed
the
update_selftests
branch
from
bc874a0
to
9055daf
Compare
|
@spuiuk one last typo in commit message Otherwise lgtm. |
spuiuk
force-pushed
the
update_selftests
branch
from
9055daf
to
49b3f82
Compare
I use a .venv directory within the repo and flake8 ends up checking the python modules within that directory. I create a section in tox.ini to exclude certain directories from flake8 checks. Signed-off-by: Sachin Prabhu <[email protected]>
Exclude files in /testcases/smbtorture/selftest/ directory from tests. Signed-off-by: Sachin Prabhu <[email protected]>
Signed-off-by: Sachin Prabhu <[email protected]>
This includes a new subdirectory expectedfail.d which includes all tests expected to always fail. Head of samba repo when this copy was made 0caaa2d1723 (vfs: Remove shadow_copy2_get_real_filename_at(), 2024-01-11) Signed-off-by: Sachin Prabhu <[email protected]>
Add the newly created directory expectedfail.d to the knownfails list for smbtorture. Signed-off-by: Sachin Prabhu <[email protected]>
anoopcs9
force-pushed
the
update_selftests
branch
from
49b3f82
to
fea076c
Compare
Shwetha-Acharya
approved these changes
Jan 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The selftest files for smbtorture tests were out of date and needed updating.
We also use this opportunity to exclude the testcases/smbtorture/selftest(and a few more directories which are not part of the repo) from various checks. This means we no longer have to first copy the files from the samba sources and then update them to work with the static checkers. This is far easier to maintain.