Skip to content

Commit

Permalink
smbtorture: Add Shadow Copy related tests
Browse files Browse the repository at this point in the history
- Some of the sparse file related tests are expected to fail due
  to limitations in CephFS, mark the same
- Make sure that ioctl tests are expected to strictly pass against
  CephFS and CephFS.vfs only.

Signed-off-by: Shwetha K Acharya <[email protected]>
  • Loading branch information
Shwetha-Acharya committed Aug 7, 2024
1 parent 5426d82 commit 2b51132
Show file tree
Hide file tree
Showing 5 changed files with 20 additions and 0 deletions.
3 changes: 3 additions & 0 deletions testcases/smbtorture/selftest/flapping.glusterfs
Original file line number Diff line number Diff line change
Expand Up @@ -10,3 +10,6 @@

#https://github.com/gluster/samba-integration/issues/241
^samba3.smb2.deny.*

# Strictly checking ioctl tests against cephFS only
^samba3.smb2.ioctl.*
3 changes: 3 additions & 0 deletions testcases/smbtorture/selftest/flapping.gpfs
Original file line number Diff line number Diff line change
Expand Up @@ -5,3 +5,6 @@
# Ignore due to lack of proper multichannel setup.
^samba3.smb2.session.bind2
^samba3.smb2.session.two_logoff

# Strictly checking ioctl tests against cephFS only
^samba3.smb2.ioctl.*
3 changes: 3 additions & 0 deletions testcases/smbtorture/selftest/flapping.xfs
Original file line number Diff line number Diff line change
Expand Up @@ -8,3 +8,6 @@

# https://github.com/samba-in-kubernetes/sit-environment/pull/109
samba3.smb2.session.reauth4

# Strictly checking ioctl tests against cephFS only
^samba3.smb2.ioctl.*
10 changes: 10 additions & 0 deletions testcases/smbtorture/selftest/knownfail.d/sparse_files
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
+# CephFS does not explicitly track which parts of a file are allocated/written with sparse files,
+# the st_blocks field is always populated by the file size divided by the block size.
+# This will cause tools like du(1) to overestimate consumed space.
+# (The recursive size field, maintained by CephFS, also includes file “holes” in its count.)
+
+# Refer: https://github.com/samba-in-kubernetes/sit-test-cases/issues/86
+^samba3.smb2.ioctl.sparse_punch
+^samba3.smb2.ioctl.sparse_qar_ob1
+^samba3.smb2.ioctl.sparse_punch_invalid
+^samba3.smb2.ioctl.copy-chunk streams
1 change: 1 addition & 0 deletions testcases/smbtorture/smbtorture-tests-info.yml
Original file line number Diff line number Diff line change
Expand Up @@ -31,3 +31,4 @@
- smb2.bench
- smb2.winattr2
- smb2.charset
- smb2.ioctl

0 comments on commit 2b51132

Please sign in to comment.