config: restrict deployments to amd64 nodes #328
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
synarete
force-pushed
the
ss-restrict-deployment-amd64
branch
from
2978d9e
to
8b8e13c
Compare
|
🎉 All dependencies have been resolved ! |
synarete
force-pushed
the
ss-restrict-deployment-amd64
branch
from
8b8e13c
to
586918b
Compare
|
@phlogistonjohn wrote.
Not sure it is required because the original contributor @tiferrei of #326 is still t author of this PR's commit which also carries their signoff line |
Until samba-operator supports other architectures (namely, ARM64), restrict its deployment to AMD64 nodes (e.g., in cases of non x86_64 or mixed ARCH clusters) via standard K8s node-selector mechanism [1]. [1] https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/ Signed-off-by: Tiago Ferreira <[email protected]> Co-authored-by: Shachar Sharon <[email protected]>
synarete
force-pushed
the
ss-restrict-deployment-amd64
branch
from
586918b
to
6134073
Compare
phlogistonjohn
approved these changes
Feb 13, 2024
|
/retest centos-ci/sink-clustered/mini-k8s-latest |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Until samba-operator supports other architectures (namely, ARM64), restrict its deployment to AMD64 nodes (e.g., in cases of non x86_64 or mixed ARCH clusters) via standard K8s node-selector mechanism [1].
[1] https://kubernetes.io/docs/concepts/scheduling-eviction/assign-pod-node/
depends on #329