Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Explicitly restrict to amd64 hosts #326

Closed
wants to merge 2 commits into from
Closed

Explicitly restrict to amd64 hosts #326

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f6528cf
config: restrict deployments to amd64 nodes
tiferrei Jan 21, 2024
4fde3a4
config: fix indentation in affinity block
tiferrei Feb 9, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions config/manager-full/auth_proxy_patch.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,6 +8,15 @@ metadata:
spec:
template:
spec:
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: beta.kubernetes.io/arch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

key should be kubernetes.io/arch. See k8s labels-annotations-taints docs as well kubernetes/kubernetes#73333

Note that we already use those values for samba pods' selector: https://github.com/samba-in-kubernetes/samba-operator/blob/master/internal/planner/selector.go#L14

operator: In
values:
- amd64
containers:
- name: kube-rbac-proxy
# this is apparently the same code as
Expand Down
9 changes: 9 additions & 0 deletions config/manager/manager.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -31,6 +31,15 @@ spec:
kubectl.kubernetes.io/default-logs-container: manager
kubectl.kubernetes.io/default-container: manager
spec:
affinity:
nodeAffinity:
requiredDuringSchedulingIgnoredDuringExecution:
nodeSelectorTerms:
- matchExpressions:
- key: beta.kubernetes.io/arch
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same comment as above: should be kubernetes.io/arch

operator: In
values:
- amd64
containers:
- command:
- /manager
Expand Down
Loading