Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user-segment.service specs #195

Closed
wants to merge 19 commits into from
Closed

user-segment.service specs #195

wants to merge 19 commits into from

Conversation

1010varun
Copy link
Contributor

@1010varun 1010varun commented Jul 25, 2023

Comment on lines +8 to +24
describe('TransformerController', () => {
let controller: TransformerController;

const mockTransformerData = {
id: '123',
createdAt: 1000,
updatedAt: 1000,
name: 'mockTransformerService',
service: { create: 'create' },
tags: ['tag1', 'tag2'],
config: {
value: '123',
},
};

const mockTransformerService = {
create: jest.fn((data) => {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @1010varun this PR is supposed to contain test fixes for user-segment.service but it contains changes for transformer.controller as well which as addressed on this PR. Can you clean this PR up to only contain the necessary changes after rebasing from the latest develop branch?

@gitguardian
Copy link

gitguardian bot commented Aug 6, 2023

⚠️ GitGuardian has uncovered 1 secret following the scan of your pull request.

Please consider investigating the findings and remediating the incidents. Failure to do so may lead to compromising the associated services or software components.

🔎 Detected hardcoded secret in your pull request
GitGuardian id Secret Commit Filename
934781 Generic High Entropy Secret 3d2f7f1 src/.env.sample View secret
🛠 Guidelines to remediate hardcoded secrets
  1. Understand the implications of revoking this secret by investigating where it is used in your code.
  2. Replace and store your secret safely. Learn here the best practices.
  3. Revoke and rotate this secret.
  4. If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.

To avoid such incidents in the future consider


🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.

Our GitHub checks need improvements? Share your feedbacks!

@1010varun 1010varun closed this Aug 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants