-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
user-segment.service specs #195
Conversation
Develop merge
merge develop
Develop merge
Develop Merge
describe('TransformerController', () => { | ||
let controller: TransformerController; | ||
|
||
const mockTransformerData = { | ||
id: '123', | ||
createdAt: 1000, | ||
updatedAt: 1000, | ||
name: 'mockTransformerService', | ||
service: { create: 'create' }, | ||
tags: ['tag1', 'tag2'], | ||
config: { | ||
value: '123', | ||
}, | ||
}; | ||
|
||
const mockTransformerService = { | ||
create: jest.fn((data) => { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @1010varun this PR is supposed to contain test fixes for user-segment.service
but it contains changes for transformer.controller
as well which as addressed on this PR. Can you clean this PR up to only contain the necessary changes after rebasing from the latest develop
branch?
* Removed search/internal endpoint. * Added functionality to sort search by field.
Co-authored-by: Chinmoy Chakraborty <[email protected]>
|
GitGuardian id | Secret | Commit | Filename | |
---|---|---|---|---|
934781 | Generic High Entropy Secret | 3d2f7f1 | src/.env.sample | View secret |
🛠 Guidelines to remediate hardcoded secrets
- Understand the implications of revoking this secret by investigating where it is used in your code.
- Replace and store your secret safely. Learn here the best practices.
- Revoke and rotate this secret.
- If possible, rewrite git history. Rewriting git history is not a trivial act. You might completely break other contributing developers' workflow and you risk accidentally deleting legitimate data.
To avoid such incidents in the future consider
- following these best practices for managing and storing secrets including API keys and other credentials
- install secret detection on pre-commit to catch secret before it leaves your machine and ease remediation.
🦉 GitGuardian detects secrets in your source code to help developers and security teams secure the modern development process. You are seeing this because you or someone else with access to this repository has authorized GitGuardian to scan your pull request.
Our GitHub checks need improvements? Share your feedbacks!
#143