Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed failing tests in NetcoreServiceTest and SunbirdWebPortalAdapterTest #29

Merged

Conversation

chinmoy12c
Copy link
Member

Fixes: #28

@chinmoy12c
Copy link
Member Author

chinmoy12c commented Apr 26, 2023

Hey @pankajjangid05, we've moved the OkHttpClient outside and autowired it instead of creating an object ourselves. We have also set NETCORE_WHATSAPP_AUTH_TOKEN in the constructor instead of passing it from getInstance method. We need to test if everything is working fine with netcore. Also, we need to clean up the code to get NewNetcoreService instance using @service and autowiring it instead of using the getInstance method. Tracking it here: #30

@chinmoy12c chinmoy12c changed the base branch from master to development April 28, 2023 06:29
@pankajjangid05 pankajjangid05 merged commit 57d2c28 into samagra-comms:development Apr 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Some test cases failing on stable branches (Adapter)
2 participants