Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add squid to $PATH and add squid to CMD #11

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sickcodes
Copy link

Doesn't change any existing scripts.

-d detached mode instead of &

Allows use of -e CONF=squid.conf.https_port when docker running

@@ -16,8 +16,17 @@ To run the image, simply invoke a shell in the container and start squid in the
are interested in:


```bash
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

suggest a table with all the config values

To run the image, either specify the configuration you need or run in an interactive shell

Configuration File Description
squid.conf.forward explicit forward proxy mode intercepts HTTP traffic and uses CONNECT for https. (default)
squid.conf.cache squid proxy which will cache upstream content
squid.conf.https_port forward proxy with HTTPS listener for squid
squid.conf.basicauth enable basic authentication with username/password
squid.conf.allow_domain forward proxy that allows access to specific domain
squid.conf.intercept intercept and inspect SSL Traffic
# detached background run (uses squid.conf.forward)
docker run -d -p 3128:3128 docker.io/salrashid123/squidproxy

# alternative configuration file
docker run -it -p 3128:3128 -e CONF=squid.conf.intercept docker.io/salrashid123/squidproxy
# interactive
docker run -it -p 3128:3128 docker.io/salrashid123/squidproxy /bin/bash

@salrashid123
Copy link
Owner

LGTM. thanks

added a formatting comment. The default behavior of running the container will change though

eg,
running docker run -it -p 3128:3128 docker.io/salrashid123/squidproxy used to drop you into a shell

and after this, the same command will auto-launch squid in forward mode.


i don't see it as a big deal since the docs stated you should invoke /bin/bash to get a shell anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants