feat: use peerDeps for LWC #386
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nolanlawson
commented
Sep 5, 2024
| "@lwc/synthetic-shadow": "7.1.2", | ||
| "@lwc/wire-service": "7.1.2", | ||
| "@salesforce/wire-service-jest-util": "4.1.4", | ||
| "@salesforce/wire-service-jest-util": "^4.1.4", |
There was a problem hiding this comment.
Using a caret to avoid the need to keep bumping this project when the other one changes.
nolanlawson
commented
Sep 5, 2024
| "eslint": "^8.57.0", | ||
| "husky": "^9.0.11", | ||
| "isbinaryfile": "^5.0.2", | ||
| "lint-staged": "^15.2.2", | ||
| "prettier": "^3.2.5" | ||
| }, | ||
| "peerDependencies": { | ||
| "@lwc/engine-dom": ">= 5", |
There was a problem hiding this comment.
Matching the current peerDep for @lwc/jest-preset on @lwc/engine-dom.
|
Now that I'm looking at this, this is a lot to ask of people, since you have to install ~5 packages alongside this one. Maybe we are better off just leaving it as deps for now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
BREAKING CHANGE: All
@lwc/*and@lwc/jest-*dependencies are nowpeerDependenciesrather than regular dependencies, so they must be installed alongside@salesforce/sfdx-lwc-jestby consumers of this package.To upgrade, you can do:
Fixes #349