build: update to axe v4.2 #67
Conversation
update expected a11y issues count accordingly
due to automatic checks issue with circus salesforce#65
Codecov Report
@@ Coverage Diff @@
## master #67 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 19 19
Lines 234 235 +1
Branches 31 31
=========================================
+ Hits 234 235 +1
|
|
Will investigate the codecov drop.. |
This reverts commit 8ac5bb4 due to salesforce#65
mohanraj-r
changed the title
|
Had to revert back to Jest v26 from attempted upgrade to v27 due to inconsistencies in code cov reports as noted in #65 |
| @@ -46,7 +46,7 @@ describe('toBeAccessible jest a11y matcher', () => { | |||
|
|
|||
| it.each(a11yConfigParams)('should throw error for dom with a11y issues with config: %#', async (config) => { | |||
| document.body.innerHTML = domWithA11yIssues; | |||
| expect.assertions(a11yIssuesCount); | |||
| expect.assertions(a11yIssuesCount + 1); | |||
There was a problem hiding this comment.
Good catch :)
The test has 6 assertions, and a11yIssuesCount was changed from 6 to 5 in this PR to account for the removed bypass rule. But this test doesn't actually check for num of a11y issues - think it was a coincidence that the num of issues matched the num of assertions.
Removed the expectation and added a hasAssertions check to the utils method that is using the async calls.
that somehow got messed up in a recent change to update links to v4.2
add sanity check of assertions to utils method
mohanraj-r
force-pushed
the
build_update_axe_v4.2
branch
from
2fbe3cc
to
0950925
Compare
This reverts commit 597c89e.
rearrange doc layout to move automatic checks down after API
|
@trevor-bliss Can you please review the latest changes. I accidentally dismissed your approval. |
|
Opened issue in axe-core dequelabs/axe-core#3055 |
Build 🏗️
bypass)