chore(template-compiler): normalize class and style attribute values #4553
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ekashida
commented
Sep 16, 2024
| @@ -1,7 +1,7 @@ | |||
| import _implicitStylesheets from "./static-content-optimization.css"; | |||
| import _implicitScopedStylesheets from "./static-content-optimization.scoped.css?scoped=true"; | |||
| import { freezeTemplate, parseFragment, registerTemplate } from "lwc"; | |||
| const $fragment1 = parseFragment`<div${3}><span${"a1:data-dynamic"}${3}></span><span data-static="bar"${3}></span><span${"s3"}${3}></span><span style="quux"${3}></span><span${3}>${"t6"}</span><span${"a7:data-dynamic"}${"s7"}${"c7"}${2}>${"t8"}</span></div>`; | |||
| const $fragment1 = parseFragment`<div${3}><span${"a1:data-dynamic"}${3}></span><span data-static="bar"${3}></span><span${"s3"}${3}></span><span style=""${3}></span><span${3}>${"t6"}</span><span${"a7:data-dynamic"}${"s7"}${"c7"}${2}>${"t8"}</span></div>`; | |||
There was a problem hiding this comment.
Need to remove the style attribute in the case where its value is an empty string.
wjhsf
approved these changes
Sep 17, 2024
ekashida
commented
Sep 17, 2024
packages/@lwc/template-compiler/src/codegen/static-element-serializer.ts
Outdated
Show resolved
Hide resolved
nolanlawson
approved these changes
Sep 17, 2024
nolanlawson
reviewed
Sep 17, 2024
...ages/@lwc/integration-karma/test/rendering/style-class-whitespace/x/component/component.html
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Details
Fixes #4124
Does this pull request introduce a breaking change?
Does this pull request introduce an observable change?
GUS work item
W-16419702