Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #10208 - Workflow Calculated Fields Relationship Parameters DropDown missing #10216

Closed
wants to merge 1 commit into from
Closed

Fix #10208 - Workflow Calculated Fields Relationship Parameters DropDown missing #10216

wants to merge 1 commit into from

Conversation

serhiisamko091184
Copy link
Contributor

@serhiisamko091184 serhiisamko091184 commented Oct 2, 2023 •
edited
Loading

Description

See:
#10208

A bit more details:

  1. As function edit_display receives an empty array of parameters it's imposible to concatenate script through condition on the next screen-shot:
    image

image

  1. Without field dropdown, as consequence, another piece of logic is obviously broken:
    image

Motivation and Context

Add missing dropdown and make it working:
image

How To Test This

See:
#10208

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Final checklist

  • My code follows the code style of this project found here.
  • My change requires a change to the documentation.
  • I have read the How to Contribute guidelines.

@jack7anderson7 jack7anderson7 added Status: Requires Code Review Needs the core team to code review Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Testing Requires Manual Testing PR 4-8 Score given to PRs once assessed Branch:Hotfix labels Oct 3, 2023
clemente-raposo
clemente-raposo reviewed Oct 12, 2023
View reviewed changes
modules/AOW_Actions/actions/actionComputeField.php
Comment on lines -485 to -495

$('#$containerName .computeFieldParametersContainer').find('.parameterSelect').change(function () {
onFieldChange$line(this, $('#$containerName .computeFieldParametersContainer').find('.parameterTypeSelect'));
});

$('#$containerName .computeFieldRelationParametersContainer').find('.relationParameterFieldSelect').change(function () {
onFieldChange$line(this, $('#$containerName .computeFieldRelationParametersContainer').find('.relationParameterTypeSelect'));
});

$('#$containerName .computeFieldParametersContainer').find('.parameterSelect').change();
$('#$containerName .computeFieldRelationParametersContainer').find('.relationParameterFieldSelect:visible').change();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @serhiisamko091184, why do we need to remove these lines?

And if we need to remove them, why do we keep the function onFieldChange$line(dropdown, valueDropdown) definition?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @clemente-raposo,
thanks for asking,

The main idea was to bring back missing functionality via avoiiding that check - if (count($params) > 0).
Maybe, we can keep them.
I assume it's maybe not convenient to have raw/formated value added when certain criteria met

image
image

I decided to remove that logic and have those fields present all the time.

Yes, I forgot to delete it from the script.

If we are OK with usual behaviour, as presented in documentation, I can just bring those lines back in the code base.

Thanks.

Regards,
Serhii

@johntnz johntnz mentioned this pull request Sep 9, 2024
Open
@serhiisamko091184
Copy link
Contributor Author

Duplicate of:
#10517

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@clemente-raposo clemente-raposo clemente-raposo left review comments

Assignees
No one assigned
Labels
Branch:Hotfix PR 4-8 Score given to PRs once assessed Status:Assessed PRs that have been tested and confirmed to resolve an issue by a core team member Status: Requires Code Review Needs the core team to code review Status: Requires Testing Requires Manual Testing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@serhiisamko091184 @clemente-raposo @jack7anderson7