Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Preventing crash when assigning product to shipping rate #5188

Merged
merged 4 commits into from
Oct 9, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Sep 30, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@poulch poulch requested a review from a team as a code owner September 30, 2024 19:50
Copy link

changeset-bot bot commented Sep 30, 2024

🦋 Changeset detected

Latest commit: efc30c3

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5188 September 30, 2024 19:57 Destroyed
Copy link
Member

@Cloud11PL Cloud11PL left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉

@poulch poulch added run e2e Runs cypress end-to-end tests run pw-e2e and removed run e2e Runs cypress end-to-end tests labels Oct 1, 2024
@github-actions github-actions bot temporarily deployed to pr-5188 October 1, 2024 14:06 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5188 October 1, 2024 16:39 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5188 October 1, 2024 19:51 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5188 October 2, 2024 11:51 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5188 October 7, 2024 11:52 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5188 October 8, 2024 12:11 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5188 October 8, 2024 12:35 Destroyed
@poulch poulch merged commit 8bf935a into main Oct 9, 2024
14 of 15 checks passed
@poulch poulch deleted the merx-1011-fix-shiping-error branch October 9, 2024 09:04
poulch added a commit that referenced this pull request Oct 11, 2024
* Fix reading id of undefined products

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants