Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add service worker and show banner when update or offline #5081

Closed
wants to merge 23 commits into from
Closed

Add service worker and show banner when update or offline #5081

wants to merge 23 commits into from

Conversation

poulch
Copy link
Member

@poulch poulch commented Jul 30, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: 887a540

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 10:00 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 10:19 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 10:54 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 11:18 Destroyed
@poulch poulch changed the title Add Vite PWA plugin Add service worker and show banner when update or offline Jul 30, 2024
@poulch poulch marked this pull request as ready for review July 30, 2024 11:35
@poulch poulch requested a review from a team as a code owner July 30, 2024 11:35
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 11:38 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 12:08 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 12:17 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 13:04 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5081 July 30, 2024 13:27 Destroyed
@poulch
Copy link
Member Author

poulch commented Jul 30, 2024

We've decided to close PR due to it not giving us any benefit. The users have to refresh the page to see the notification banner when using a service worker but without it when refreshed, they'd get a new version of the dashboard.
To recap, there are no benefits with using a service worker for updating the Dashboard version.

@poulch poulch closed this Jul 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@2can 2can Awaiting requested review from 2can 2can is a code owner automatically assigned from saleor/ui-guild

@krzysztofzuraw krzysztofzuraw Awaiting requested review from krzysztofzuraw krzysztofzuraw is a code owner automatically assigned from saleor/ui-guild

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poulch @andrzejewsky