Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always send required attribute #5075

Merged
merged 6 commits into from
Jul 31, 2024
Merged

Always send required attribute #5075

merged 6 commits into from
Jul 31, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Jul 26, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Jul 26, 2024

🦋 Changeset detected

Latest commit: 66fa737

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5075 July 26, 2024 15:16 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5075 July 29, 2024 10:09 Destroyed
@poulch poulch marked this pull request as ready for review July 29, 2024 10:18
@poulch poulch requested a review from a team as a code owner July 29, 2024 10:18
@github-actions github-actions bot temporarily deployed to pr-5075 July 29, 2024 11:53 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5075 July 29, 2024 12:36 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5075 July 29, 2024 12:56 Destroyed
@poulch poulch merged commit 46fd7bb into main Jul 31, 2024
15 checks passed
@poulch poulch deleted the merx-618-required-attribute branch July 31, 2024 10:00
Cloud11PL pushed a commit that referenced this pull request Aug 2, 2024
* Always send required attribute

* Handle empty numeric attribute value

* Add changeset
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants