Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[E2E] Fix auth file playwright and small refactor #5065

Merged
merged 3 commits into from
Jul 25, 2024

Conversation

yellowee
Copy link
Contributor

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@yellowee yellowee self-assigned this Jul 25, 2024
Copy link

changeset-bot bot commented Jul 25, 2024

🦋 Changeset detected

Latest commit: fde0d4c

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5065 July 25, 2024 07:54 Destroyed
@yellowee
Copy link
Contributor Author

yellowee commented Jul 25, 2024

TC 2111 failure is a known issue and will be fixed in https://linear.app/saleor/issue/QAG-146/fix-failing-tests-in-runs-on-pr-environments , the test passes locally and it also was tested manually

@yellowee yellowee marked this pull request as ready for review July 25, 2024 08:10
@yellowee yellowee requested review from a team as code owners July 25, 2024 08:10
@yellowee yellowee marked this pull request as draft July 25, 2024 09:19
@yellowee yellowee requested a review from karola312 July 25, 2024 09:29
@github-actions github-actions bot temporarily deployed to pr-5065 July 25, 2024 09:32 Destroyed
@yellowee yellowee marked this pull request as ready for review July 25, 2024 09:38
playwright/api/basics.ts Outdated Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to pr-5065 July 25, 2024 11:02 Destroyed
@yellowee yellowee requested a review from szczecha July 25, 2024 11:05
playwright/api/basics.ts Outdated Show resolved Hide resolved
@yellowee yellowee requested a review from szczecha July 25, 2024 11:26
@github-actions github-actions bot temporarily deployed to pr-5065 July 25, 2024 11:28 Destroyed
@yellowee yellowee enabled auto-merge (squash) July 25, 2024 13:45
@yellowee yellowee merged commit ce08614 into main Jul 25, 2024
12 checks passed
@yellowee yellowee deleted the fix_auth_file_playwright branch July 25, 2024 13:46
@yellowee yellowee mentioned this pull request Jul 26, 2024
7 tasks
yellowee added a commit that referenced this pull request Jul 30, 2024
* fix for auth and save state function

* small refactor

* adding conditional assertion for TC 137
yellowee added a commit that referenced this pull request Jul 30, 2024
* [E2E] Fix auth file playwright and small refactor (#5065)

* fix for auth and save state function

* small refactor

* adding conditional assertion for TC 137

* e2e auth backport with a fix for  attr  test
michalina-graczyk added a commit that referenced this pull request Jul 31, 2024
michalina-graczyk added a commit that referenced this pull request Jul 31, 2024
michalina-graczyk added a commit that referenced this pull request Jul 31, 2024
michalina-graczyk added a commit that referenced this pull request Jul 31, 2024
Cloud11PL pushed a commit that referenced this pull request Aug 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants