Fix search by order number in Navigator #5063
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 7f345a1 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
poulch
previously approved these changes
Jul 23, 2024
Co-authored-by: Paweł Chyła <[email protected]>
poulch
previously approved these changes
Jul 24, 2024
poulch
previously approved these changes
Jul 25, 2024
Comment on lines
16
to
19
| const { result } = renderHook(() => useQuickOrderSearch()); | ||
|
|
||
| // Act | ||
| act(() => result.current[1]("1234")); |
There was a problem hiding this comment.
Suggested change
| const { result } = renderHook(() => useQuickOrderSearch()); | |
| // Act | |
| act(() => result.current[1]("1234")); | |
| const { result } = renderHook(() => useQuickOrderSearch()); | |
| const [_, setQueryDebounced] = result.current | |
| // Act | |
| act(() => setQueryDebounced("1234")); |
poulch
approved these changes
Jul 26, 2024
andrzejewsky
approved these changes
Jul 29, 2024
| orderNumber, | ||
| }), | ||
| onClick: () => { | ||
| navigate(orderUrl(order.id)); |
There was a problem hiding this comment.
can't entries be a links? navigation based on onClick are hacky a bit
There was a problem hiding this comment.
I can improve it in the scope of the general Navigator improvements ticket (it's in backlog)
Cloud11PL
added a commit
that referenced
this pull request
Jul 30, 2024
* use search by order number * fixes * Update src/components/NavigatorSearch/modes/orders.ts Co-authored-by: Paweł Chyła <[email protected]> * lint * add test for making search query * improve test --------- Co-authored-by: Paweł Chyła <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description