Replace all environment variables instead of only API_URL #5055
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: ff0c53c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
|
lkostrowski
reviewed
Jul 19, 2024
There was a problem hiding this comment.
I think the improvement is great.
@krzysztofzuraw can you verify this against your latest work on dockerization?
NyanKiyoshi
previously approved these changes
Jul 22, 2024
poulch
previously approved these changes
Jul 25, 2024
nginx/replace-api-url.sh
Outdated
There was a problem hiding this comment.
Good job - works as it should - can you change the filename to replace-env-vars instead of replace-api-url.sh?
poulch
previously approved these changes
Jul 29, 2024
NyanKiyoshi
previously approved these changes
Jul 30, 2024
poulch
approved these changes
Aug 1, 2024
NyanKiyoshi
approved these changes
Aug 1, 2024
krzysztofzuraw
approved these changes
Aug 1, 2024
|
@yasinuslu thank you for your work 🙇🏻♂️ |
Cloud11PL
pushed a commit
that referenced
this pull request
Aug 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Instead of replacing only the API_URL, docker image now replaces all environment variables available to the index.html
Usage Instructions, Screenshots, Recordings
Have you written tests?
replace-api-url.shit didn't have tests before, so I didn't add it. We can figure out a way to write a test for it if you request it.[Optional] Description