Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove old select fields after migration #5035

Merged
merged 51 commits into from
Jul 26, 2024
Merged

Remove old select fields after migration #5035

merged 51 commits into from
Jul 26, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Jul 8, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: 8da9b7e

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

Base automatically changed from merx-644-replace-old-select to main July 16, 2024 08:25
@github-actions github-actions bot temporarily deployed to pr-5035 July 16, 2024 09:33 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5035 July 22, 2024 07:51 Destroyed
@poulch poulch changed the title Remove not used components Remove old select fields after migration Jul 22, 2024
@poulch poulch marked this pull request as ready for review July 22, 2024 07:57
@poulch poulch requested a review from a team as a code owner July 22, 2024 07:57
@github-actions github-actions bot temporarily deployed to pr-5035 July 22, 2024 07:58 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5035 July 25, 2024 09:03 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5035 July 25, 2024 09:32 Destroyed
@poulch poulch merged commit 862e5dc into main Jul 26, 2024
15 checks passed
@poulch poulch deleted the remove-legacy-dropdowns branch July 26, 2024 07:21
Cloud11PL pushed a commit that referenced this pull request Jul 30, 2024
* Replace old SingleSelectField with new in AttributeDetails

* Replace Select in NumericUnits

* Replace Select in ChannelDeleteDialog

* Replace Select in AppChannelSelect

* Replace Select in FilterSingleSelectField

* Replace Select in PhoneField

* Replace rest Select

* Migrade change shipping dialog, fix tests

* Change locators

* Fix add shipping method

* Replace empty strings

* Fix attrb and tax select locators

* Update attributeReferencesEntities

* Fix tag page

* Fix home page channel select test

* Add changeset

* Fix ts

* Replace multiselect

* Fix AttributeDetails select

* Fix NumericUnits select

* Add new action dialog

* Change ActionModal in ChannelDeleteDialog and rename name

* Set const width to AppChannelSelect

* Add now border

* Adjust GiftCardSendToCustomer

* Adjust OrderShippingMethodEditDialog

* Adjust TaxAppLabel

* Extract messages

* Update changeset

* Fix typo

* Fix OrderShippingMethodEditDialog

* Remove not used components

* Use Option type

* Add changeset

* Extract messages
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants