Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add serial mode to playwright setup - login via API #5032

Merged
merged 1 commit into from
Jul 8, 2024

Conversation

karola312
Copy link
Member

@karola312 karola312 commented Jul 8, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

After new CORE release (Implement login throttling), playwright tests had failures in setup (logging in with users, with different permissions via API) - only 10% of tests were successful. Running setup in serial mode (in one worker) fixes this issue.

Copy link

changeset-bot bot commented Jul 8, 2024

🦋 Changeset detected

Latest commit: fcce44f

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5032 July 8, 2024 11:18 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5032 July 8, 2024 11:33 Destroyed
@karola312 karola312 marked this pull request as ready for review July 8, 2024 12:01
@karola312 karola312 requested review from a team as code owners July 8, 2024 12:01
@karola312 karola312 requested review from 2can and witoszekdev and removed request for a team July 8, 2024 12:01
@karola312 karola312 merged commit 592979a into 3.19 Jul 8, 2024
19 of 21 checks passed
@karola312 karola312 deleted the Add-serial-mode-to-playwright-setup branch July 8, 2024 12:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants