Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace old MultiAutocompleteSelectField with new Multiselect #5022

Merged
merged 14 commits into from
Jul 4, 2024

Conversation

poulch
Copy link
Member

@poulch poulch commented Jul 3, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

In Shipping details, I've added a button to create a new warehouse. Previously that button was embed in multiselect, out current implementation doesn't allow this
Screenshot 2024-07-03 at 22 59 32

@poulch poulch requested a review from a team as a code owner July 3, 2024 21:12
@poulch poulch requested review from 2can and witoszekdev July 3, 2024 21:12
Copy link

changeset-bot bot commented Jul 3, 2024

🦋 Changeset detected

Latest commit: 836c940

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-5022 July 3, 2024 21:18 Destroyed
@poulch poulch requested a review from a team as a code owner July 4, 2024 09:18
@github-actions github-actions bot temporarily deployed to pr-5022 July 4, 2024 09:20 Destroyed
Droniu
Droniu previously approved these changes Jul 4, 2024
@github-actions github-actions bot temporarily deployed to pr-5022 July 4, 2024 10:21 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5022 July 4, 2024 10:49 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5022 July 4, 2024 11:07 Destroyed
@github-actions github-actions bot temporarily deployed to pr-5022 July 4, 2024 11:50 Destroyed
@poulch poulch merged commit dfb19e5 into main Jul 4, 2024
15 checks passed
@poulch poulch deleted the merx-643-replace-mutli-autocomplete branch July 4, 2024 13:07
Cloud11PL pushed a commit that referenced this pull request Jul 8, 2024
* Replace old MultiAutocompleteSelectField with new in AccountPermissionGroups

* Replace old MultiAutocompleteSelectField with new in ChannelSelection

* Replace old MultiAutocompleteSelectField with new in WerehousesSection with add new warehouse button

* Add changeset

* Update locators

* Fix channel locator

* Fix test when multipe selected channels

* Fix warehouse selector

* Update changeset

* Fix verifyAssignedPermission

* Fix verifyAssignedPermission and Multiselect when options is undefined
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants