Add placeholder to price cells in product list #4972
Conversation
🦋 Changeset detectedLatest commit: 96506e5 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
| params.append(`0[s0.${ProductFilterKeys.channel}]`, ""); | ||
|
|
||
| history.replace({ search: params.toString() }); |
There was a problem hiding this comment.
suggestion: This will not work when someone has already selected some filters
.changeset/selfish-walls-sit.md
Outdated
| "saleor-dashboard": minor | ||
| --- | ||
|
|
||
| Product list no longer show a dash instead of product's price when channel is not selected. Instead 'Select channel' shortcut was added meaning that you can now use it to open filters window with 'channel' already selected. |
There was a problem hiding this comment.
It can be simpler and a bit shorter:
You can now open channel selection by clicking "Select channel" within any price cell on the product list. This means the dash "-" sign is no longer displayed there
| const params = new URLSearchParams(search); | ||
|
|
||
| const filtersIndices = Array.from(params.keys()) | ||
| .map(key => { |
There was a problem hiding this comment.
this whole map can be a dedicated function, the name will indicate what you map to
|
|
||
| const handlePriceClick = (productId: string) => { | ||
| if (!productId) return; | ||
|
|
||
| history.replace({ search: getPriceClickSearchParams(history.location.search) }); | ||
|
|
||
| filterWindow.setOpen(true); | ||
| }; |
There was a problem hiding this comment.
issue: you just smuggled here the price-related logic, to the component that is already large and mixing a variety of contexts. You can create hook for it instead and use it here to encapsulate that logic
There was a problem hiding this comment.
the hook could return for you an adapter as well so the preparation of it also could be moved
1 failed and 2 flaky tests on run #6249 ↗︎
Details:
|
|||||||||||||||||||||||||||||||||
| Test | Artifacts | |
|---|---|---|
| An uncaught error was detected outside of a test |
Screenshots
|
|
apps.js • 1 flaky test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| As a staff user I want to manage apps > should be able to create app. TC: SALEOR_3001 |
Screenshots
|
|
configuration/shippingMethods/channelsInShipping.js • 1 flaky test • UI - Electron
| Test | Artifacts | |
|---|---|---|
| As a staff user I want have different shipping method prices for each channel > should be able to display different price for each channel. TC: SALEOR_0805 |
Screenshots
|
|
Review all test suite changes for PR #4972 ↗︎
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description