Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[QA] Fixing flaky navigation tests TC: SALEOR_198 and TC: SALEOR_194 #4854

Merged
merged 3 commits into from
May 13, 2024

Conversation

yellowee
Copy link
Contributor

@yellowee yellowee commented May 9, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@yellowee yellowee self-assigned this May 9, 2024
Copy link

changeset-bot bot commented May 9, 2024

🦋 Changeset detected

Latest commit: 7364bb0

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4854 May 9, 2024 13:20 Destroyed
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_194 branch from d94de6a to 4ae9a29 Compare May 10, 2024 06:12
@github-actions github-actions bot temporarily deployed to pr-4854 May 10, 2024 06:14 Destroyed
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_194 branch from 4ae9a29 to d9290ea Compare May 10, 2024 10:25
@github-actions github-actions bot temporarily deployed to pr-4854 May 10, 2024 10:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4854 May 10, 2024 12:19 Destroyed
@yellowee yellowee force-pushed the QA_fix_flaky_test_TC_SALEOR_194 branch from 00c1100 to 023d177 Compare May 10, 2024 12:24
@github-actions github-actions bot temporarily deployed to pr-4854 May 10, 2024 12:26 Destroyed
@yellowee yellowee marked this pull request as ready for review May 10, 2024 12:41
@yellowee yellowee requested review from a team as code owners May 10, 2024 12:41
@yellowee yellowee marked this pull request as draft May 13, 2024 08:44
@yellowee yellowee merged commit 618bb01 into main May 13, 2024
15 checks passed
@yellowee yellowee deleted the QA_fix_flaky_test_TC_SALEOR_194 branch May 13, 2024 10:21
Copy link

cypress bot commented May 14, 2024

2 flaky tests on run #6197 ↗︎

0 243 8 0 Flakiness 2

Details:

Triggered via release - CORE 3.18.46-3486a2a,
Project: Saleor Commit: ad6c8b7c0f
Status: Passed Duration: 10:32 💡
Started: May 21, 2024 10:37 AM Ended: May 21, 2024 10:47 AM
Flakiness  discounts/vouchers/updateVouchers.js • 1 flaky test • UI - Electron

View Output

Test Artifacts
As an admin I want to update vouchers > should set end date on voucher. TC: SALEOR_1913 Screenshots
Flakiness  apps.js • 1 flaky test • UI - Electron

View Output

Test Artifacts
As a staff user I want to manage apps > should be able to create webhook. TC: SALEOR_3002 Screenshots

Review all test suite changes for PR #4854 ↗︎

karola312 pushed a commit that referenced this pull request May 23, 2024
…4854)

* Fix_flaky_navigation_tests

* Fixing SALEOR_33

* Fixing SALEOR_106
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants