Disable checkbox for products that are not available in selected channels #4841
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: e4ab56c The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Cloud11PL
requested review from
witoszekdev and
lkostrowski
and removed request for
a team
|
@poulch this branch will be merged to the one you mentioned 😄 |
yellowee
approved these changes
May 8, 2024
poulch
reviewed
May 8, 2024
andrzejewsky
approved these changes
May 10, 2024
andrzejewsky
requested changes
May 10, 2024
There was a problem hiding this comment.
Hey @Cloud11PL please review @poulch pull request because seems like he did something very similar or even exact as you here. While code can be different, we should keep the same consistency between those UI
Cloud11PL
added a commit
that referenced
this pull request
May 17, 2024
#4826) * Get product search channel listing * Show is product incuded in selected channels * Disable checkbox and show info when no channels overlap * Add changeset * Make solution more general * Add selected channels to other dialogs * Update fixture * Update changset * Fix types * Update mocks * Extract messages * Update messages * Disable checkbox for products that are not available in selected channels (#4841) * check if product is available in channel * add changesets * show message why product's disabled * extract messages * Unify assign product modals (#4864) --------- Co-authored-by: Wojciech Mista <[email protected]>
karola312
pushed a commit
that referenced
this pull request
May 23, 2024
#4826) * Get product search channel listing * Show is product incuded in selected channels * Disable checkbox and show info when no channels overlap * Add changeset * Make solution more general * Add selected channels to other dialogs * Update fixture * Update changset * Fix types * Update mocks * Extract messages * Update messages * Disable checkbox for products that are not available in selected channels (#4841) * check if product is available in channel * add changesets * show message why product's disabled * extract messages * Unify assign product modals (#4864) --------- Co-authored-by: Wojciech Mista <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
Related Issues or Documents
Usage Instructions, Screenshots, Recordings
Have you written tests?
[Optional] Description