Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TEST] [E2E] Added test for setting balance and exporting gift cards #4650

Merged
merged 12 commits into from
Mar 15, 2024
Merged

[TEST] [E2E] Added test for setting balance and exporting gift cards #4650

merged 12 commits into from
Mar 15, 2024

Conversation

karola312
Copy link
Member

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

  • closes #

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: Writing tests are mandatory, please replace this text with why test are not included in this PR

[Optional] Description

@karola312 karola312 requested a review from a team as a code owner January 30, 2024 15:20
@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jan 30, 2024 •
edited
Loading

🦋 Changeset detected

Latest commit: db23b91

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@karola312 karola312 marked this pull request as draft January 30, 2024 15:20
@github-actions github-actions bot temporarily deployed to pr-4650 January 30, 2024 15:22 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4650 January 30, 2024 15:22 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4650 January 30, 2024 15:35 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4650 January 30, 2024 15:35 Destroyed
@karola312 karola312 marked this pull request as ready for review January 30, 2024 15:37
@karola312 karola312 marked this pull request as draft January 31, 2024 09:40
yellowee
yellowee previously approved these changes Jan 31, 2024
View reviewed changes
@github-actions github-actions bot temporarily deployed to pr-4650 January 31, 2024 09:49 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4650 January 31, 2024 09:50 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4650 January 31, 2024 12:06 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4650 January 31, 2024 12:07 Destroyed
@karola312 karola312 enabled auto-merge (squash) February 5, 2024 11:11
@github-actions github-actions bot temporarily deployed to pr-4650 February 5, 2024 11:14 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4650 February 5, 2024 11:14 Destroyed
@github-actions GitHub Actions
Copy link

This pull request is stale because it has been open 14 days with no activity.

@github-actions github-actions bot added the stale label Feb 20, 2024
@github-actions github-actions bot temporarily deployed to storybook pr-4650 February 20, 2024 11:24 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4650 February 20, 2024 11:24 Destroyed
@github-actions github-actions bot removed the stale label Feb 21, 2024
andrzejewsky
andrzejewsky requested changes Feb 26, 2024
View reviewed changes
.github/workflows/pr-automation.yml
@@ -208,6 +208,7 @@ jobs:
E2E_USER_NAME: ${{ secrets.CYPRESS_USER_NAME }}
E2E_USER_PASSWORD: ${{ secrets.CYPRESS_USER_PASSWORD }}
E2E_PERMISSIONS_USERS_PASSWORD: ${{ secrets.CYPRESS_PERMISSIONS_USERS_PASSWORD }}
MAILPITURL: ${{ secrets.CYPRESS_MAILPITURL }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's not cypress, i think you meant ${{ secrets.MAILPITURL }}

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you approve it and maybe in next PR I will fix all variables: CYPRESS_MAILPITURL, CYPRESS_PERMISSIONS_USERS_PASSWORD, CYPRESS_USER_PASSWORD, CYPRESS_USER_NAME etc.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What is the status of it? Those comments has 3 weeks

.github/workflows/run-test-cron.yml
@@ -63,6 +63,7 @@ jobs:
E2E_USER_NAME: ${{ secrets.CYPRESS_USER_NAME }}
E2E_USER_PASSWORD: ${{ secrets.CYPRESS_USER_PASSWORD }}
E2E_PERMISSIONS_USERS_PASSWORD: ${{ secrets.CYPRESS_PERMISSIONS_USERS_PASSWORD }}
MAILPITURL: ${{ secrets.CYPRESS_MAILPITURL }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

same here

.github/workflows/run-test-manual.yml
@@ -70,6 +70,7 @@ jobs:
E2E_USER_NAME: ${{ secrets.CYPRESS_USER_NAME }}
E2E_USER_PASSWORD: ${{ secrets.CYPRESS_USER_PASSWORD }}
E2E_PERMISSIONS_USERS_PASSWORD: ${{ secrets.CYPRESS_PERMISSIONS_USERS_PASSWORD }}
MAILPITURL: ${{ secrets.CYPRESS_MAILPITURL }}
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

and here

@karola312 karola312 requested review from a team as code owners March 14, 2024 09:05
@github-actions github-actions bot temporarily deployed to storybook pr-4650 March 14, 2024 09:10 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4650 March 14, 2024 09:10 Destroyed
andrzejewsky
andrzejewsky reviewed Mar 15, 2024
View reviewed changes
Copy link
Member

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what's the status?

@karola312
Copy link
Member Author

Waiting for review from SRE, not able to merge before that

@karola312 karola312 merged commit dbfe9b7 into main Mar 15, 2024
15 checks passed
@karola312 karola312 deleted the tests-for-setting-balance-and-exporting-gift-cards branch March 15, 2024 11:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzejewsky andrzejewsky andrzejewsky approved these changes

@NyanKiyoshi NyanKiyoshi NyanKiyoshi approved these changes

@yellowee yellowee yellowee approved these changes

@wojteknowacki wojteknowacki wojteknowacki approved these changes

@poulch poulch Awaiting requested review from poulch poulch was automatically assigned from saleor/dashboard

@michalina-graczyk michalina-graczyk Awaiting requested review from michalina-graczyk michalina-graczyk is a code owner automatically assigned from saleor/qa-guild

Assignees
No one assigned
Labels
e2e-migration
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@karola312 @NyanKiyoshi @andrzejewsky @yellowee @michalina-graczyk @wojteknowacki