Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make discount rules flag visible #4624

Merged
merged 1 commit into from
Jan 12, 2024
Merged

Conversation

andrzejewsky
Copy link
Member

@andrzejewsky andrzejewsky commented Jan 12, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: _It makes feature flag visible; configuration

[Optional] Description

@andrzejewsky andrzejewsky requested a review from a team as a code owner January 12, 2024 10:18
Copy link

changeset-bot bot commented Jan 12, 2024

🦋 Changeset detected

Latest commit: 27a6fac

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@andrzejewsky andrzejewsky merged commit 1a32555 into main Jan 12, 2024
20 checks passed
@andrzejewsky andrzejewsky deleted the enable-discount-rules-flag branch January 12, 2024 12:21
andrzejewsky added a commit that referenced this pull request Jan 12, 2024
Copy link

cypress bot commented Jan 12, 2024

2 failed and 2 flaky tests on run #5966 ↗︎

2 240 7 2 Flakiness 2

Details:

Triggered via release - CORE 3.18.13-85d81e6,
Project: Saleor Commit: 9ee9392473
Status: Failed Duration: 11:18 💡
Started: Feb 2, 2024 5:03 PM Ended: Feb 2, 2024 5:14 PM
Failed  apps.js • 1 failed test • UI - Electron

View Output

Test Artifacts
As a staff user I want to manage apps > should be able to create webhook. TC: SALEOR_3002 Screenshots
Failed  orders/transactionsForOrders.js • 1 failed test • UI - Electron

View Output

Test Artifacts
Orders > should mark order as paid. TC: 3901 Screenshots
Flakiness  cypress/e2e/discounts/vouchers/updateVouchers.js • 2 flaky tests • UI - Electron

View Output

Test Artifacts
As an admin I want to update vouchers > should set end date on voucher. TC: SALEOR_1913 Screenshots
As an admin I want to update vouchers > should set country on voucher. TC: SALEOR_1914 Screenshots

Review all test suite changes for PR #4624 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: 👀 In Review
Development

Successfully merging this pull request may close these issues.

2 participants