Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TEST] [E2E] Delete shipping method from the shipping zone details page #4611

Merged
merged 4 commits into from
Jan 12, 2024

Conversation

yellowee
Copy link
Contributor

@yellowee yellowee commented Jan 9, 2024

What type of PR is this?

  • 💅 Refactor
  • 🌟 Feature
  • 🔥 Bug Fix
  • 🔩 Maintenance
  • 🛠 Workflow CI/CD changes

Related Issues or Documents

Usage Instructions, Screenshots, Recordings

Have you written tests?

  • Yes!
  • No... here is why: the pr introduces new test scenario

[Optional] Description

It covers TC SALEOR_34

Copy link

changeset-bot bot commented Jan 9, 2024

🦋 Changeset detected

Latest commit: 2414101

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-4611 January 9, 2024 07:22 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 9, 2024 07:22 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4611 January 9, 2024 08:05 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 9, 2024 08:05 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 9, 2024 08:11 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4611 January 9, 2024 08:11 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4611 January 9, 2024 08:34 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 9, 2024 08:34 Destroyed
@yellowee yellowee marked this pull request as ready for review January 9, 2024 08:46
@yellowee yellowee requested a review from a team as a code owner January 9, 2024 08:46
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 9, 2024 08:57 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4611 January 9, 2024 08:57 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4611 January 9, 2024 09:11 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 9, 2024 09:16 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4611 January 9, 2024 09:16 Destroyed
playwright/tests/shippingMethods.spec.ts Outdated Show resolved Hide resolved
playwright/tests/shippingMethods.spec.ts Outdated Show resolved Hide resolved
@yellowee yellowee force-pushed the test_delete_shipping_method branch 4 times, most recently from b5cbf2c to 32a61ae Compare January 10, 2024 09:39
@yellowee yellowee marked this pull request as ready for review January 10, 2024 10:44
@github-actions github-actions bot temporarily deployed to pr-4611 January 10, 2024 16:26 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 10, 2024 16:26 Destroyed
Copy link
Member

@andrzejewsky andrzejewsky left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Seems like your test is not working + please fix the CI checks, eg. ts check

yellowee and others added 3 commits January 11, 2024 09:27
* Migrated warehouses tests: Edit warehouse; Delete warehouse

* Migrated categories tests: Create basic category; Edit category;Bulk delete categories

* Migrated warehouses tests: Edit warehouse; Delete warehouse (#4593)

* Migrated warehouses tests: Edit warehouse; Delete warehouse

* Update nervous-flowers-hear.md

* Update nervous-flowers-hear.md

* Use composites in pr automation workflow (#4597)

* Use composites

* Use composites

* Use composites

* Use composites

* Use composites

* changed shipping metod id in shippings tests

* maintenance

* add console log to goto details page actions

* Trigger Build

* Create ten-feet-roll.md

---------

Co-authored-by: Patryk Andrzejewski <[email protected]>
@github-actions github-actions bot temporarily deployed to storybook pr-4611 January 11, 2024 08:29 Destroyed
@github-actions github-actions bot temporarily deployed to pr-4611 January 11, 2024 08:29 Destroyed
@yellowee yellowee dismissed stale reviews from andrzejewsky and michalina-graczyk January 11, 2024 10:55

fixes applied, but review status is not changing

@andrzejewsky andrzejewsky merged commit 621c368 into main Jan 12, 2024
24 checks passed
@andrzejewsky andrzejewsky deleted the test_delete_shipping_method branch January 12, 2024 08:40
@wojteknowacki wojteknowacki added this to the Saleor 3.19 milestone Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: No status
Development

Successfully merging this pull request may close these issues.

4 participants