Improvments for discount catalog #4565
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 57f4d2b The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
github-actions
bot
temporarily deployed
to
pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
pr-discount-catalog-optimistic-uptades
andrzejewsky
previously approved these changes
Jan 3, 2024
...counts/components/DiscountRules/componenets/RulesList/components/RuleSummary/RuleSummary.tsx
Outdated
Show resolved
Hide resolved
src/discounts/views/DiscountDetails/hooks/useFetchConditionsOptionsDetails.ts
Outdated
Show resolved
Hide resolved
src/discounts/views/DiscountDetails/hooks/usePromotionRuleCreate.ts
Outdated
Show resolved
Hide resolved
src/discounts/views/DiscountDetails/hooks/usePromotionRuleDelete.ts
Outdated
Show resolved
Hide resolved
src/discounts/views/DiscountDetails/hooks/usePromotionRuleUpdate.ts
Outdated
Show resolved
Hide resolved
github-actions
bot
temporarily deployed
to
pr-discount-catalog-optimistic-uptades
github-actions
bot
temporarily deployed
to
storybook pr-discount-catalog-optimistic-uptades
Droniu
approved these changes
Jan 4, 2024
andrzejewsky
approved these changes
Jan 4, 2024
andrzejewsky
pushed a commit
that referenced
this pull request
Jan 12, 2024
* Add empty column to datagrid * Fix loading of rules * Update rule validation * Show rule summary when no conditions * Handle labels on rule update * Improve loading rules * Handle show selected labels * Fix rules tests * Update labels on rule add * Improve adding condtions * Move reward value to left * Remove optional from description * Fix show channel error * Add changeset * Update test * Bump macaw * Sort rule by name * Improve details form submission * Prevent refetch, write data into cache * Improve rule sorting and update mutations * Fix loading issue * Fix ts issues * Refactor to separate hooks * Fix richtext * Refactor useRulesHandlers to get rid of rules state and get data from api * Show only initial loading * Refactor and improve loading conditions options * Fix jumpy condition multiselect * Fix input heigh equal * Change discount type switch height * After CR improvments * Fix ts issues
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #...
Screenshots
Pull Request Checklist
data-test-idare added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=2