Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix mulitselect height in filters #4564

Merged
merged 9 commits into from
Jan 4, 2024
Merged

Fix mulitselect height in filters #4564

merged 9 commits into from
Jan 4, 2024

Conversation

krzysztofzuraw
Copy link
Member

@krzysztofzuraw krzysztofzuraw commented Dec 20, 2023

closes #...

Screenshots

Before After
CleanShot 2023-12-20 at 12 53 52@2x CleanShot 2023-12-20 at 12 53 03@2x

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets file (instructions in contribution guide

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=2

Copy link

changeset-bot bot commented Dec 20, 2023

🦋 Changeset detected

Latest commit: 054c7ca

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs December 20, 2023 11:56 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs December 20, 2023 11:56 Destroyed
@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs December 21, 2023 13:30 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs December 21, 2023 13:30 Destroyed
@krzysztofzuraw krzysztofzuraw marked this pull request as ready for review December 21, 2023 13:32
@krzysztofzuraw krzysztofzuraw requested a review from a team as a code owner December 21, 2023 13:32
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs December 21, 2023 13:34 Destroyed
@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs December 21, 2023 13:34 Destroyed
@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs January 3, 2024 09:27 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs January 3, 2024 09:27 Destroyed
@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs January 3, 2024 09:31 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs January 3, 2024 09:31 Destroyed
andrzejewsky
andrzejewsky previously approved these changes Jan 3, 2024
@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs January 3, 2024 11:48 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs January 3, 2024 11:48 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs January 3, 2024 13:14 Destroyed
@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs January 3, 2024 13:14 Destroyed
@github-actions github-actions bot temporarily deployed to pr-fix-filter-inputs January 3, 2024 14:11 Destroyed
@github-actions github-actions bot temporarily deployed to storybook pr-fix-filter-inputs January 3, 2024 14:11 Destroyed
@poulch poulch merged commit a2bac68 into main Jan 4, 2024
14 of 16 checks passed
@poulch poulch deleted the fix-filter-inputs branch January 4, 2024 08:45
andrzejewsky pushed a commit that referenced this pull request Jan 12, 2024
* Fix mulitselect height in filters

* update pkg json & changeset

* rerun CI

* remove tgz

---------

Co-authored-by: Paweł Chyła <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants