-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix duplicates when assigning reference attributes & eligible entities for vouchers and products #4412
Conversation
🦋 Changeset detectedLatest commit: 6ae4def The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
const filteredProducts = filterProducts(products, attribute); | ||
const filteredPages = filterPages(pages, attribute); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: for me it's a little bit not clear what does filterPages function
type SearchCategoriesOpts = ReturnType<typeof useCategorySearch>["result"]; | ||
type SearchCollectionOpts = ReturnType<typeof useCollectionSearch>["result"]; | ||
type SearchProductsOpts = ReturnType<typeof useProductSearch>["result"]; | ||
|
||
type SaleOrVoucherData = SaleDetailsQuery | VoucherDetailsQuery; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
suggestion: those line can be move to const.ts
closes #4315
Screenshots
Pull Request Checklist
data-test-id
are added for new elementsTest environment config
API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps
Do you want to run more stable tests?
To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.
CONTAINERS=6