Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Migrate product variant page #4209

Merged
merged 27 commits into from
Oct 5, 2023
Merged

Migrate product variant page #4209

merged 27 commits into from
Oct 5, 2023

Conversation

poulch
Copy link
Member

@poulch poulch commented Sep 19, 2023

closes #4010

Screenshots

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=6

@changeset-bot
Copy link

changeset-bot bot commented Sep 19, 2023

🦋 Changeset detected

Latest commit: b9b21fa

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page September 19, 2023 13:39 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page September 19, 2023 13:39 Destroyed
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page September 25, 2023 10:08 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page September 25, 2023 10:08 Destroyed
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page September 25, 2023 12:06 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page September 25, 2023 12:06 Destroyed
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page September 25, 2023 18:29 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page September 25, 2023 18:29 Destroyed
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page September 26, 2023 09:13 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page September 26, 2023 09:13 Destroyed
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page September 28, 2023 09:51 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page September 28, 2023 09:51 Destroyed
@wojteknowacki wojteknowacki added the run e2e Runs cypress end-to-end tests label Oct 4, 2023
@poulch poulch added the run chromatic Run Chromatic visual tests on PR label Oct 4, 2023
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page October 4, 2023 14:19 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page October 4, 2023 14:19 Destroyed
@poulch poulch added run chromatic Run Chromatic visual tests on PR and removed run e2e Runs cypress end-to-end tests run chromatic Run Chromatic visual tests on PR labels Oct 4, 2023
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page October 4, 2023 15:56 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4010-migrate-variant-page October 4, 2023 15:56 Destroyed
@poulch poulch added run chromatic Run Chromatic visual tests on PR and removed run chromatic Run Chromatic visual tests on PR labels Oct 4, 2023
@github-actions github-actions bot temporarily deployed to 4010-migrate-variant-page October 4, 2023 16:32 Destroyed
@poulch poulch added run chromatic Run Chromatic visual tests on PR and removed run chromatic Run Chromatic visual tests on PR labels Oct 4, 2023
@wojteknowacki wojteknowacki self-requested a review October 5, 2023 07:07
@poulch poulch merged commit 29b8740 into main Oct 5, 2023
26 checks passed
@poulch poulch deleted the 4010-migrate-variant-page branch October 5, 2023 07:08
@poulch poulch restored the 4010-migrate-variant-page branch July 1, 2024 11:26
@poulch poulch deleted the 4010-migrate-variant-page branch July 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run chromatic Run Chromatic visual tests on PR
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Migrate variant page to new macaw
4 participants