Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New column picker for variant datagrid #4086

Merged
merged 22 commits into from
Sep 25, 2023
Merged

Conversation

Droniu
Copy link
Member

@Droniu Droniu commented Aug 16, 2023

closes #4007

Screenshots

Before:
image

After:
image

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. app
  3. attribute
  4. category
  5. collection
  6. customer
  7. giftCard
  8. homePage
  9. login
  10. menuNavigation
  11. navigation
  12. orders
  13. pages
  14. payments
  15. permissions
  16. plugins
  17. productType
  18. products
  19. sales
  20. shipping
  21. translations
  22. variants
  23. vouchers

CONTAINERS=1

@changeset-bot
Copy link

changeset-bot bot commented Aug 16, 2023

🦋 Changeset detected

Latest commit: 1fb4927

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to 4007-column-picker-on-variants August 16, 2023 09:29 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4007-column-picker-on-variants August 16, 2023 09:29 Inactive
@github-actions github-actions bot temporarily deployed to 4007-column-picker-on-variants August 23, 2023 18:13 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4007-column-picker-on-variants August 23, 2023 18:13 Inactive
@Droniu Droniu marked this pull request as ready for review August 24, 2023 00:25
@Droniu Droniu requested a review from a team as a code owner August 24, 2023 00:25
@github-actions github-actions bot temporarily deployed to 4007-column-picker-on-variants August 24, 2023 00:26 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4007-column-picker-on-variants August 24, 2023 00:26 Inactive
poulch
poulch previously approved these changes Aug 24, 2023
@Droniu Droniu marked this pull request as draft August 30, 2023 09:18
@github-actions github-actions bot temporarily deployed to 4007-column-picker-on-variants September 1, 2023 11:15 Inactive
@github-actions github-actions bot temporarily deployed to storybook 4007-column-picker-on-variants September 1, 2023 11:15 Inactive
@github-actions github-actions bot temporarily deployed to 4007-column-picker-on-variants September 7, 2023 10:35 Destroyed
@Droniu Droniu requested a review from poulch September 7, 2023 10:35
@github-actions github-actions bot temporarily deployed to storybook 4007-column-picker-on-variants September 7, 2023 10:35 Destroyed
andrzejewsky
andrzejewsky previously approved these changes Sep 15, 2023
poulch
poulch previously approved these changes Sep 19, 2023
@Droniu Droniu dismissed stale reviews from poulch and andrzejewsky via dd1e372 September 21, 2023 11:50
@github-actions github-actions bot temporarily deployed to 4007-column-picker-on-variants September 21, 2023 11:50 Destroyed
@github-actions github-actions bot temporarily deployed to storybook 4007-column-picker-on-variants September 21, 2023 11:50 Destroyed
poulch
poulch previously approved these changes Sep 21, 2023
@Droniu Droniu requested a review from poulch September 25, 2023 08:56
@Droniu Droniu merged commit 5b4cf7d into main Sep 25, 2023
13 of 14 checks passed
@Droniu Droniu deleted the 4007-column-picker-on-variants branch September 25, 2023 08:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
4 participants