Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Drop dynamic column toggles in column picker #3878

Merged
merged 13 commits into from
Jul 12, 2023
Merged

Drop dynamic column toggles in column picker #3878

merged 13 commits into from
Jul 12, 2023

Conversation

Droniu
Copy link
Member

@Droniu Droniu commented Jul 6, 2023 •
edited
Loading

closes #3686

This change simplifies column picker architecture. We no longer need dual local storage for managing indeterminate columns

New architecture

image

Screenshots

image

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core
  6. I added changesets and read good practices

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=4

@changeset-bot
Copy link

changeset-bot bot commented Jul 6, 2023 •
edited
Loading

🦋 Changeset detected

Latest commit: 7096981

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
saleor-dashboard Minor

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@github-actions github-actions bot temporarily deployed to 3686-remove-dynamic-column-toggles July 6, 2023 12:52 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3686-remove-dynamic-column-toggles July 6, 2023 12:52 Inactive
@github-actions github-actions bot temporarily deployed to 3686-remove-dynamic-column-toggles July 7, 2023 07:45 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3686-remove-dynamic-column-toggles July 7, 2023 07:45 Inactive
@github-actions github-actions bot temporarily deployed to 3686-remove-dynamic-column-toggles July 10, 2023 05:46 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3686-remove-dynamic-column-toggles July 10, 2023 05:46 Inactive
@Droniu Droniu marked this pull request as ready for review July 10, 2023 05:51
@Droniu Droniu requested a review from a team as a code owner July 10, 2023 05:51
poulch
poulch previously approved these changes Jul 10, 2023
View reviewed changes
Copy link
Member

@poulch poulch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, gr8 job

andrzejewsky
andrzejewsky previously approved these changes Jul 10, 2023
View reviewed changes
@Droniu Droniu dismissed stale reviews from andrzejewsky and poulch via 1fdd418 July 10, 2023 09:47
@github-actions github-actions bot temporarily deployed to 3686-remove-dynamic-column-toggles July 10, 2023 09:48 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3686-remove-dynamic-column-toggles July 10, 2023 09:48 Inactive
poulch
poulch previously approved these changes Jul 10, 2023
View reviewed changes
@wojteknowacki
Copy link
Member

Pagination issue when removing dynamic and static columns

Nagranie.z.ekranu.2023-07-11.o.08.35.45.mov

@wojteknowacki wojteknowacki added the run e2e Runs cypress end-to-end tests label Jul 11, 2023
@github-actions github-actions bot temporarily deployed to 3686-remove-dynamic-column-toggles July 12, 2023 07:57 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3686-remove-dynamic-column-toggles July 12, 2023 07:57 Inactive
poulch
poulch previously approved these changes Jul 12, 2023
View reviewed changes
@wojteknowacki
Test column picker: adding, removing and searching for dynamic column…
4187aed 
…s in picker (#3901)

* test - column picker. Adding, removing and searching for dynamic columns in picker.

* update tests tame with TC ids

* removed unused row checks on products list view
@github-actions github-actions bot temporarily deployed to 3686-remove-dynamic-column-toggles July 12, 2023 10:22 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3686-remove-dynamic-column-toggles July 12, 2023 10:22 Inactive
@github-actions github-actions bot temporarily deployed to 3686-remove-dynamic-column-toggles July 12, 2023 10:37 Inactive
@wojteknowacki wojteknowacki self-requested a review July 12, 2023 11:58
@Droniu Droniu merged commit 66976d5 into main Jul 12, 2023
11 of 14 checks passed
@Droniu Droniu deleted the 3686-remove-dynamic-column-toggles branch July 12, 2023 11:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@andrzejewsky andrzejewsky andrzejewsky approved these changes

@poulch poulch poulch approved these changes

@wojteknowacki wojteknowacki wojteknowacki approved these changes

@krzysztofzuraw krzysztofzuraw Awaiting requested review from krzysztofzuraw krzysztofzuraw was automatically assigned from saleor/dashboard

Assignees
No one assigned
Labels
run e2e Runs cypress end-to-end tests
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Column picker - dynamic columns should not be togglable
4 participants
@Droniu @wojteknowacki @andrzejewsky @poulch