Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use Accordion component from new macaw #3712

Merged
merged 22 commits into from
Jul 10, 2023
Merged

Use Accordion component from new macaw #3712

merged 22 commits into from
Jul 10, 2023

Conversation

poulch
Copy link
Member

@poulch poulch commented May 31, 2023

closes #3704

Accordion has been changed here:

  • Configuration / Channel details right sidebar Warehouses and Shipping Zones
  • Products export dialog
  • Channel availability card in Collection, Sales, Vouchers, Product, Shipping zone create and details page
  • Filter content in all places where filter is used
  • Timeline event use for example in order and gift card history
  • Product variant details - available channels

Screenshots

Before After
Screenshot 2023-06-28 at 10 10 35 Screenshot 2023-06-28 at 10 10 48
Before After
Screenshot 2023-06-28 at 10 18 11 Screenshot 2023-06-28 at 10 18 03
Before After
Screenshot 2023-06-28 at 10 23 41 Screenshot 2023-06-28 at 10 23 50
Before After
Screenshot 2023-06-28 at 10 31 27 Screenshot 2023-06-28 at 10 31 58
Before After
Screenshot 2023-06-28 at 10 34 55 Screenshot 2023-06-28 at 10 35 30

Pull Request Checklist

  1. This code contains UI changes
  2. All visible strings are translated with proper context including data-formatting
  3. Attributes data-test-id are added for new elements
  4. The changes are tested in Chrome/Firefox/Safari browsers and in light/dark mode
  5. Your code works with the latest stable version of the core

Test environment config

API_URI=https://automation-dashboard.staging.saleor.cloud/graphql/
APPS_MARKETPLACE_API_URI=https://apps.staging.saleor.io/api/v2/saleor-apps

Do you want to run more stable tests?

To run all tests, just select the stable checkbox. To speed up tests, increase the number of containers. Tests will be re-run only when the "run e2e" label is added.

  1. stable
  2. giftCard
  3. category
  4. collection
  5. attribute
  6. productType
  7. shipping
  8. customer
  9. permissions
  10. menuNavigation
  11. pages
  12. sales
  13. vouchers
  14. homePage
  15. login
  16. orders
  17. products
  18. app
  19. plugins
  20. translations
  21. navigation
  22. variants
  23. payments

CONTAINERS=6

@github-actions github-actions bot temporarily deployed to 3704-replace-accordion May 31, 2023 15:02 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3704-replace-accordion May 31, 2023 15:02 Inactive
@github-actions github-actions bot temporarily deployed to 3704-replace-accordion June 1, 2023 12:18 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3704-replace-accordion June 1, 2023 12:18 Inactive
@poulch poulch marked this pull request as ready for review June 1, 2023 12:44
@poulch poulch requested a review from a team as a code owner June 1, 2023 12:44
krzysztofzuraw
krzysztofzuraw previously approved these changes Jun 1, 2023
src/components/Timeline/TimelineEvent.tsx Outdated Show resolved Hide resolved
src/components/Timeline/TimelineEvent.tsx Show resolved Hide resolved
@github-actions github-actions bot temporarily deployed to 3704-replace-accordion June 1, 2023 13:08 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3704-replace-accordion June 1, 2023 13:08 Inactive
krzysztofzuraw
krzysztofzuraw previously approved these changes Jun 1, 2023
andrzejewsky
andrzejewsky previously approved these changes Jun 2, 2023
@github-actions github-actions bot temporarily deployed to 3704-replace-accordion June 12, 2023 08:07 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3704-replace-accordion June 12, 2023 08:07 Inactive
@github-actions github-actions bot temporarily deployed to 3704-replace-accordion June 12, 2023 08:07 Inactive
@github-actions github-actions bot temporarily deployed to 3704-replace-accordion July 5, 2023 11:23 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3704-replace-accordion July 5, 2023 11:23 Inactive
@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

image

This is intentional that accordion content is indented compared to the accordion trigger, and this is how it works currently on staging.

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

The whole row could be clickable on filters - now only the txt field and radio button is clickable image

I confirm. This is very unintuitive

I've decided to not include Filter as it will be replaced be new component

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

image

As I've described above, Filter is not part of this PR.

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

image

Seem to be 1 to 1 with stagging, Imo is intentionally to not use accordion here

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

Untitled_.Jul.4.2023.2_23.PM.webm

  1. Go to orders
  2. Go into random order details
  3. Go to the order history
  4. Click on the arrow - nothing happened

it looks like we implement a dead feature. What should happen when I click there?

This will be fixed in this PR

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

image What is the first letter in the countries ?

This is not an accordion component but only looks similar. IMO we can migrate this component during whole page migration to new macaw

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

Timeline event use for example in order and gift card history -> can't see it, am I on wrong view?

image image

You were in good view but not all history events have accordion.
Example for orders: https://3704-replace-accordion.dashboard.saleor.rocks/orders/T3JkZXI6YzkxZTQzMDMtOGNlOS00ZDRlLTk2OGYtMmZjMGI5NjdmMmIy
I coundn't found an example for gift card but this is the same component as in order history.

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

Product variant details - available channels How it should looks on this view? Current: image

By ``Product variant details ` I mean this view: https://3704-replace-accordion.dashboard.saleor.rocks/products/UHJvZHVjdDo3Nw%3D%3D/variant/UHJvZHVjdFZhcmlhbnQ6MjE3

@poulch
Copy link
Member Author

poulch commented Jul 5, 2023

image

Please create separate issue for this

@github-actions github-actions bot temporarily deployed to 3704-replace-accordion July 5, 2023 13:31 Inactive
@github-actions github-actions bot temporarily deployed to storybook 3704-replace-accordion July 5, 2023 13:31 Inactive
@github-actions github-actions bot temporarily deployed to 3704-replace-accordion July 7, 2023 08:52 Inactive
@poulch poulch added run e2e Runs cypress end-to-end tests run chromatic Run Chromatic visual tests on PR and removed run e2e Runs cypress end-to-end tests run chromatic Run Chromatic visual tests on PR labels Jul 7, 2023
@andrzejewsky andrzejewsky self-requested a review July 10, 2023 07:51
@poulch poulch merged commit 0ea8f32 into main Jul 10, 2023
21 of 34 checks passed
@poulch poulch deleted the 3704-replace-accordion branch July 10, 2023 08:24
@poulch poulch restored the 3704-replace-accordion branch July 1, 2024 11:26
@poulch poulch deleted the 3704-replace-accordion branch July 1, 2024 11:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run chromatic Run Chromatic visual tests on PR run e2e Runs cypress end-to-end tests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Replace Accordion component
5 participants