Remove vertical lines (#4914)

Co-authored-by: Paweł Chyła <[email protected]>
saleor · Jun 4, 2024 · f95fcc4 · f95fcc4
1 parent d068eba
commit f95fcc4
Show file tree

Hide file tree

Showing 18 changed files with 22 additions and 17 deletions.
diff --git a/.changeset/stale-tigers-brush.md b/.changeset/stale-tigers-brush.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": minor
+---
+
+Vertical lines are no longer visible for read-only grid tables
diff --git a/src/attributes/components/AttributeListDatagrid/AttributeListDatagrid.tsx b/src/attributes/components/AttributeListDatagrid/AttributeListDatagrid.tsx
@@ -94,7 +94,7 @@ export const AttributeListDatagrid = ({
         hasRowHover={true}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={attributes?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/categories/components/CategoryListDatagrid/CategoryListDatagrid.tsx b/src/categories/components/CategoryListDatagrid/CategoryListDatagrid.tsx
@@ -81,7 +81,7 @@ export const CategoryListDatagrid = ({
         hasRowHover={hasRowHover}
         loading={disabled}
         columnSelect={sort !== undefined ? "single" : undefined}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rowMarkers="checkbox-visible"
         availableColumns={visibleColumns}
         rows={categories?.length ?? 0}

diff --git a/src/collections/components/CollectionListDatagrid/CollectionListDatagrid.tsx b/src/collections/components/CollectionListDatagrid/CollectionListDatagrid.tsx
@@ -136,7 +136,7 @@ export const CollectionListDatagrid = ({
         hasRowHover={hasRowHover}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={collections?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/customers/components/CustomerListDatagrid/CustomerListDatagrid.tsx b/src/customers/components/CustomerListDatagrid/CustomerListDatagrid.tsx
@@ -115,7 +115,7 @@ export const CustomerListDatagrid = ({
         hasRowHover={hasRowHover}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={customers?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/discounts/components/DiscountListDatagrid/DiscountListDatagrid.tsx b/src/discounts/components/DiscountListDatagrid/DiscountListDatagrid.tsx
@@ -102,7 +102,7 @@ export const DiscountListDatagrid = ({
         hasRowHover={hasRowHover}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 1}
+        verticalBorder={false}
         rows={promotions?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/discounts/components/SaleListDatagrid/SaleListDatagrid.tsx b/src/discounts/components/SaleListDatagrid/SaleListDatagrid.tsx
@@ -120,7 +120,7 @@ export const SaleListDatagrid = ({
         hasRowHover={hasRowHover}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={sales?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/discounts/components/VoucherCodesDatagrid/VoucherCodesDatagrid.tsx b/src/discounts/components/VoucherCodesDatagrid/VoucherCodesDatagrid.tsx
@@ -54,7 +54,7 @@ export const VoucherCodesDatagrid = ({
         hasRowHover={false}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={codes?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/discounts/components/VoucherListDatagrid/VoucherListDatagrid.tsx b/src/discounts/components/VoucherListDatagrid/VoucherListDatagrid.tsx
@@ -119,7 +119,7 @@ export const VoucherListDatagrid = ({
         hasRowHover={true}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={vouchers?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/giftCards/GiftCardsList/GiftCardsListDatagrid/GiftCardsListDatagrid.tsx b/src/giftCards/GiftCardsList/GiftCardsListDatagrid/GiftCardsListDatagrid.tsx
@@ -148,7 +148,7 @@ export const GiftCardsListDatagrid = () => {
         hasRowHover={true}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={giftCards?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.noData)}

diff --git a/src/orders/components/OrderDraftDetailsDatagrid/OrderDraftDetailsDatagrid.tsx b/src/orders/components/OrderDraftDetailsDatagrid/OrderDraftDetailsDatagrid.tsx
@@ -141,7 +141,7 @@ export const OrderDraftDetailsDatagrid = ({
         rowMarkers="none"
         columnSelect="none"
         freezeColumns={2}
-        verticalBorder={col => col > 1}
+        verticalBorder={false}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.emptyText)}
         getCellContent={getCellContent}

diff --git a/src/orders/components/OrderDraftListDatagrid/OrderDraftListDatagrid.tsx b/src/orders/components/OrderDraftListDatagrid/OrderDraftListDatagrid.tsx
@@ -103,7 +103,7 @@ export const OrderDraftListDatagrid = ({
         hasRowHover={hasRowHover}
         loading={disabled}
         availableColumns={visibleColumns}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         getCellContent={getCellContent}
         getCellError={() => false}
         menuItems={() => []}

diff --git a/src/orders/components/OrderListDatagrid/OrderListDatagrid.tsx b/src/orders/components/OrderListDatagrid/OrderListDatagrid.tsx
@@ -107,7 +107,7 @@ export const OrderListDatagrid: React.FC<OrderListDatagridProps> = ({
           columnSelect="single"
           hasRowHover={hasRowHover}
           freezeColumns={2}
-          verticalBorder={col => col > 1}
+          verticalBorder={false}
           availableColumns={visibleColumns}
           onHeaderClicked={handleHeaderClick}
           emptyText={intl.formatMessage(messages.emptyText)}

diff --git a/src/pages/components/PageListDatagrid/PageListDatagrid.tsx b/src/pages/components/PageListDatagrid/PageListDatagrid.tsx
@@ -112,7 +112,7 @@ export const PageListDatagrid = ({
         hasRowHover={hasRowHover}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={pages?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/permissionGroups/components/PermissionGroupListDatagrid/PermissionGroupListDatagrid.tsx b/src/permissionGroups/components/PermissionGroupListDatagrid/PermissionGroupListDatagrid.tsx
@@ -100,7 +100,7 @@ export const PermissionGroupListDatagrid = ({
         freezeColumns={2}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 1}
+        verticalBorder={false}
         rows={permissionGroups?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/products/components/ProductListDatagrid/ProductListDatagrid.tsx b/src/products/components/ProductListDatagrid/ProductListDatagrid.tsx
@@ -234,7 +234,7 @@ export const ProductListDatagrid: React.FC<ProductListDatagridProps> = ({
           hasRowHover={hasRowHover}
           onColumnMoved={handlers.onMove}
           onColumnResize={handlers.onResize}
-          verticalBorder={col => col > 0}
+          verticalBorder={false}
           getColumnTooltipContent={handleGetColumnTooltipContent}
           availableColumns={visibleColumns}
           onHeaderClicked={handleHeaderClicked}

diff --git a/src/shipping/components/ShippingZonesListDatagrid/ShippingZonesListDatagrid.tsx b/src/shipping/components/ShippingZonesListDatagrid/ShippingZonesListDatagrid.tsx
@@ -89,7 +89,7 @@ export const ShippingZoneListDatagrid = ({
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
         onRowSelectionChange={onSelectShippingZones}
-        verticalBorder={col => col > 0}
+        verticalBorder={false}
         rows={shippingZones?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}

diff --git a/src/staff/components/StaffListDatagrid/StaffListDatagrid.tsx b/src/staff/components/StaffListDatagrid/StaffListDatagrid.tsx
@@ -96,7 +96,7 @@ export const StaffListDatagrid = ({
         hasRowHover={true}
         onColumnMoved={handlers.onMove}
         onColumnResize={handlers.onResize}
-        verticalBorder={col => col > 1}
+        verticalBorder={false}
         rows={staffMembers?.length ?? 0}
         availableColumns={visibleColumns}
         emptyText={intl.formatMessage(messages.empty)}