Fixing e2e test case ids and failing tests on 3.19 (#5074)

* cherry pick bde2fe8 * adding changeset * fixing brackets * fixing failing tests
saleor · Jul 29, 2024 · d121d19 · d121d19
1 parent 51e293b
commit d121d19
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 5 deletions.
diff --git a/.changeset/serious-books-wave.md b/.changeset/serious-books-wave.md
@@ -0,0 +1,5 @@
+---
+"saleor-dashboard": patch
+---
+
+You can now run E2E tests on 3.19 with no issues
diff --git a/playwright/pages/pageElements/rightSideDetailsSection.ts b/playwright/pages/pageElements/rightSideDetailsSection.ts
@@ -92,7 +92,8 @@ export class RightSideDetailsPage extends BasePage {
     await this.editShippingAddressButton.click();
   }
   async clickWarehouseSelectShippingPage() {
-    await this.selectWarehouseShippingMethodButton.click();
+    await this.selectWarehouseShippingMethodButton.waitFor({ state: "visible" });
+    await this.selectWarehouseShippingMethodButton.click({ force: true });
   }
   async expectOptionsSelected(section: Locator, names: string[]) {
     for (const name of names) {
@@ -115,11 +116,11 @@ export class RightSideDetailsPage extends BasePage {
     this.clickWarehouseSelectShippingPage();
   }
   async clickChannelsSelectShippingPage() {
-    await this.selectChannelShippingPageButton.click();
+    await this.selectChannelShippingPageButton.waitFor({ state: "visible" });
+    await this.selectChannelShippingPageButton.click({ force: true });
   }
   async selectSingleChannelShippingPage(channel = "PLN") {
     await this.selectOption.filter({ hasText: `Channel-${channel}` }).click();
-    // below click hides prompted options
     this.clickChannelsSelectShippingPage();
   }
   async openChannelsDialog() {
@@ -189,6 +190,7 @@ export class RightSideDetailsPage extends BasePage {
     await this.channelSelectDialog.clickAllChannelsCheckbox();
     await this.channelSelectDialog.selectChannel(channel);
     await this.channelSelectDialog.clickConfirmButton();
+    await this.waitForDOMToFullyLoad();
   }
   async selectOneChannelAsAvailableWhenNoneSelected(channel: string) {
     await this.manageChannelsButton.click();

diff --git a/playwright/tests/discounts.spec.ts b/playwright/tests/discounts.spec.ts
@@ -371,6 +371,7 @@ const promotionsWithRules = [
   DISCOUNTS.orderPromotionWithRulesToBeDeleted,
   DISCOUNTS.catalogPromotionWithRulesToBeDeleted,
 ];
+
 for (const promotion of promotionsWithRules) {
   for (const rule of promotion.rules) {
     test(`TC: SALEOR_167 Delete promotion ${rule.name} from ${promotion.type} promotion @discounts @e2e`, async () => {
@@ -393,5 +394,5 @@ for (const promotion of promotionsWithRules) {
         `${promotion.type}: ${rule.name}`,
       );
     });
-  }
-}
+  };
+};