Skip to content

Commit

Permalink
Adding Maven Profiles (dapr#1120)
Browse files Browse the repository at this point in the history
* Adding Maven Profiles

Signed-off-by: Artur Ciocanu <[email protected]>

* Simplify profiles setup

Signed-off-by: Artur Ciocanu <[email protected]>

---------

Signed-off-by: Artur Ciocanu <[email protected]>
Co-authored-by: Artur Ciocanu <[email protected]>
  • Loading branch information
artur-ciocanu and Artur Ciocanu authored Sep 7, 2024
1 parent 4b83da6 commit cc537a4
Show file tree
Hide file tree
Showing 3 changed files with 17 additions and 16 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/build.yml
Original file line number Diff line number Diff line change
Expand Up @@ -119,7 +119,7 @@ jobs:
run: ./mvnw install -q -B -DskipTests
- name: Integration tests using spring boot version ${{ matrix.spring-boot-version }}
id: integration_tests
run: PRODUCT_SPRING_BOOT_VERSION=${{ matrix.spring-boot-version }} ./mvnw -B -f sdk-tests/pom.xml verify
run: PRODUCT_SPRING_BOOT_VERSION=${{ matrix.spring-boot-version }} ./mvnw -B -Pintegration-tests verify
- name: Upload test report for sdk
uses: actions/upload-artifact@v4
with:
Expand Down
13 changes: 9 additions & 4 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -328,10 +328,15 @@
<module>examples</module>
<!-- We are following test containers artifact convention on purpose, don't rename -->
<module>testcontainers-dapr</module>
<!-- don't add sdk-tests to the build,
it's only used for CI testing by github action
<module>sdk-tests</module>
-->
</modules>

<profiles>
<profile>
<id>integration-tests</id>
<modules>
<module>sdk-tests</module>
</modules>
</profile>
</profiles>

</project>
18 changes: 7 additions & 11 deletions sdk-tests/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -4,9 +4,14 @@
xsi:schemaLocation="http://maven.apache.org/POM/4.0.0 http://maven.apache.org/maven-v4_0_0.xsd">
<modelVersion>4.0.0</modelVersion>

<groupId>io.dapr</groupId>
<parent>
<groupId>io.dapr</groupId>
<artifactId>dapr-sdk-parent</artifactId>
<version>1.13.0-SNAPSHOT</version>
</parent>

<artifactId>dapr-sdk-tests</artifactId>
<version>0.0.0-SNAPSHOT</version>
<version>1.13.0-SNAPSHOT</version>
<name>dapr-sdk-tests</name>
<description>Tests for Dapr's Java SDK - not to be published as a jar.</description>

Expand Down Expand Up @@ -320,15 +325,6 @@
<properties>
<springboot.version>${env.PRODUCT_SPRING_BOOT_VERSION}</springboot.version>
</properties>
<dependencies>
<dependency>
<!-- Needed for dapr compatibility for spring boot versions before 2.7 -->
<groupId>com.squareup.okhttp3</groupId>
<artifactId>okhttp</artifactId>
<version>4.9.0</version>
<scope>test</scope>
</dependency>
</dependencies>
</profile>
</profiles>
</project>

0 comments on commit cc537a4

Please sign in to comment.