Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Creating keycloak workshop #14

Merged
merged 6 commits into from
Feb 19, 2021
Merged

Creating keycloak workshop #14

merged 6 commits into from
Feb 19, 2021

Conversation

mcruzdev
Copy link
Collaborator

@mcruzdev mcruzdev commented Dec 18, 2020

This PR is from #1 issue

I am creating this PR for you to see my changes and to work together
You are free to give me a suggestion and improvement

@salaboy
Copy link
Owner

salaboy commented Dec 18, 2020

@mcruzdev concentrate on adding the steps to reproduce your setup.. I can work on adding the text to explain what each step is doing..
Does that work for you?

@salaboy
Copy link
Owner

salaboy commented Jan 3, 2021

@mcruzdev let me know how can I help you to move forward with this.. it will be great if you just create section titles and add the steps.. I can add more text if needed.. I don't want you to worry too much about writing.

@salaboy
Copy link
Owner

salaboy commented Jan 13, 2021

@mcruzdev man.. this is really good.. if you can add the instructions on what needs to be modified in the gateway I can give it a try right now..

@salaboy
Copy link
Owner

salaboy commented Jan 13, 2021

@mcruzdev just as a reference.. -> https://www.baeldung.com/spring-oauth-login-webflux

@mcruzdev
Copy link
Collaborator Author

@salaboy,

I need to add some concepts about OAuth2, Keycloak and Spring OAuth2

import org.springframework.web.reactive.config.WebFluxConfigurer;

@Configuration
public class CORSConfig implements WebFluxConfigurer {
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcruzdev do we need CORS?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hello, @salaboy, Yes, once I tested without CORS and I received an error

Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@mcruzdev ok.. I will check it out...

@salaboy
Copy link
Owner

salaboy commented Jan 26, 2021

@mcruzdev this is awesome! thanks a lot for that.. I have quite a busy week, but now that tracing is almost done I will move to review all these PRs.. I will probably merge the ones in the service to give it a try and then revert back . I will keep you posted if I find issues with it.

@salaboy salaboy merged commit 43664e5 into salaboy:master Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants