PLTCONN-5210 assume external arn role #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
ruifeng-zheng-sp
force-pushed
the
rz/dev
branch
from
1553242
to
134d4e2
Compare
| this.secretAccessKey = secretAccessKey; | ||
| this.sessionToken = sessionToken; | ||
| this.expiration = expiration; | ||
| } |
There was a problem hiding this comment.
Could we call these something like AssumeAwsRoleRequest and AssumeAwsRoleResponse? Just to line up all the names.
lib/connector-handler.ts
Outdated
| assumeAwsRole(externalRoleInput: ExternalRoleInput): Promise<CredentialResponse>; | ||
| } | ||
| export class ExternalRoleInput { | ||
| externalArnRole: string; |
There was a problem hiding this comment.
Could we call this roleArn to line up with AssumeRole API call we'll eventually make?
ruifeng-zheng-sp
force-pushed
the
rz/dev
branch
from
7deb358
to
874ef2f
Compare
ruifeng-zheng-sp
force-pushed
the
rz/dev
branch
from
567c156
to
d682271
Compare
bob-potter-sp
approved these changes
Oct 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
What is the intent of this change and why is it being made?
How Has This Been Tested?
What testing have you done to verify this change?